feature: adding smarter unit test execution - #5966
Open
cmgoffena13 wants to merge 5 commits into
Open
Conversation
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
…ow too Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
mday-io
reviewed
Aug 26, 2026
| default=None, | ||
| ) | ||
| @click.option( | ||
| "--all-tests", |
Collaborator
There was a problem hiding this comment.
Most of the other flags are verb_*. should this be --include_all_tests, or something similar?
Collaborator
|
Nice idea! I do worry about the default behavior being only running impacted model's unit tests. An indirect model change could take place (i.e., things like a SQLGlot upgrade changing rendering/types, or an engine adapter change) and then tests would fail silently for a long time before it's caught. Also, would be good to add a console output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During
plan, run unit tests only for models in the plan change set (added, modified, restated).No-change plans skip tests by default.
--all-testsruns the full suite (previous default).Addresses #5965
Test Plan
--all-testsruns the full suite (including no-change plans)--skip-testsstill skips; incompatible with--all-tests--all-testsChecklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO