Repository navigation
Return an error when the source socket can't be created - #82
Merged
stewartadam merged 1 commit intoNov 12, 2026
Merged
Conversation
Socket::new was unwrapped, so SacnSource construction panicked instead of returning the Io error its docs promise, for example when IPv6 is unavailable or the process is out of file descriptors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KzaQVPkrkczgX2g7wGkip5
stewartadam
deleted the
claude/project-thread-0t11p6-2-socket-new-error
branch
November 12, 2026 09:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SacnSourceInternal::with_cid_ipcalledSocket::new(...).unwrap(), so creating aSacnSourcepanicked when the OS refused the socket, for example when IPv6 is unavailable or the process is out of file descriptors. The function's docs already say it returns anIoerror in that case. This replaces bothunwrap()calls with?.There's no regression test, because making
socket(2)fail on demand would need fault injection. The rest of the constructor already propagates errors the same way.