Support 'of object' and 'reference to' in procedural types - #348
Open
De-Novo-Research wants to merge 1 commit into
Open
De-Novo-Research wants to merge 1 commit into
De-Novo-Research wants to merge 1 commit into
Conversation
Both variants were parsed correctly but then discarded, leaving the syntax tree unable to distinguish three types Delphi treats as distinct: procedure(...) tkProcedure procedure(...) of object tkMethod reference to procedure(...) tkInterface 'of object' produced a tree byte-identical to a plain procedural type, and 'reference to' produced no TYPE node at all - PARAMETERS hung directly off TYPEDECL. Functions were affected the same way. Both now carry a kind= attribute, following the existing interface / dispinterface precedent: <TYPE name="procedure"/> <TYPE name="procedure" kind="ofobject"/> <TYPE name="procedure" kind="referenceto"/> AnonymousMethodType inlined NextToken at the point where the procedure or function token is current, so there was no hook to record which it was. Added AnonymousMethodKind, mirroring the existing MethodKind; its base implementation is just NextToken, so behaviour is unchanged for any existing subclass that does not override it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both variants were parsed correctly but then discarded, leaving the syntax tree unable to distinguish three types Delphi treats as distinct:
procedure(...) tkProcedure
procedure(...) of object tkMethod
reference to procedure(...) tkInterface
'of object' produced a tree byte-identical to a plain procedural type, and 'reference to' produced no TYPE node at all - PARAMETERS hung directly off TYPEDECL. Functions were affected the same way.
Both now carry a kind= attribute, following the existing interface / dispinterface precedent:
AnonymousMethodType inlined NextToken at the point where the procedure or function token is current, so there was no hook to record which it was. Added AnonymousMethodKind, mirroring the existing MethodKind; its base implementation is just NextToken, so behaviour is unchanged for any existing subclass that does not override it.