Repository navigation
Tighter validation of id_token_hint at endsession endpoint. - #186
Merged
Merged
Conversation
JoStevensRSK
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change ensures that the token passed as id_token_hint at the end session endpoint has its
typvalidated against an allowlist defined inIdentityServerOptions.IdentityTokenJwtTypes, and ensures the token has a subjectId and that subjectId matches the current subject.While the introspection weakness in Duende is not present in Open.IdentityServer, as only ApiResources can access the introspection endpoint, the access token from an ApiResource with the same name as a ClientId could be used at the end session endpoint to logout and redirect to that clients post_logout_redirect.
Type of change
Does this PR introduce a breaking change?
Does the change cause a breaking change to any of the following?
Testing
Additional unit and integration tests added.
LLM Usage
Research and test code.