Skip to content

fix: renew deletes session when subjectId changes, and also doesn't create session when existing session is missing - #185

Merged
jhbritton-RSK merged 1 commit into
mainfrom
bug/#7
Nov 18, 2026
Merged

jhbritton-RSK merged 1 commit into
mainfrom
bug/#7

Conversation

@jhbritton-RSK

@jhbritton-RSK jhbritton-RSK commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Description

  • Security fix for a session fixation vulnerability when server-side sessions are enabled.
  • Fixes an issue allowing a session to be recreated when renewal is in flight as a session has expired.

Type of change

  • Bug fix
  • Feature
  • Refactoring
  • Documentation
  • Other

Does this PR introduce a breaking change?

n/a

Testing

Added unit tests and integration tests. And tested locally with a reproduction scenario.

LLM Usage

Used to generate a reproduction to validate the fix

Other context

…reate session when existing session is missing
@jhbritton-RSK
jhbritton-RSK merged commit d4d8663 into main Nov 18, 2026
3 checks passed
@jhbritton-RSK
jhbritton-RSK deleted the bug/#7 branch November 18, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants