Skip to content

fix: incorrect display name value used when session ticket is renewed - #182

Merged
jhbritton-RSK merged 2 commits into
mainfrom
bug/#180
Nov 18, 2026
Merged

jhbritton-RSK merged 2 commits into
mainfrom
bug/#180

Conversation

@jhbritton-RSK

@jhbritton-RSK jhbritton-RSK commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Session renewal ignored the server-side session setting specifying the claim to use for the display name property.

Added test cases for unprotecting auth ticket data and serialising an unprotecting payload that throws errors.

Type of change

  • Bug fix
  • Feature
  • Refactoring
  • Documentation
  • Other

Does this PR introduce a breaking change?

n/a

Testing

Added a unit test for each bug fixed

LLM Usage

Used to review the unit tests and store the file to look for any other possible bugs. Found an issue with unprotecting, and deserialising unprotected data not being handled correctly and throwing errors.

Other context

Closes: #180

@jhbritton-RSK jhbritton-RSK added the bug Something isn't working label Nov 16, 2026
@jhbritton-RSK
jhbritton-RSK merged commit 1f17c13 into main Nov 18, 2026
3 checks passed
@jhbritton-RSK
jhbritton-RSK deleted the bug/#180 branch November 18, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ServerSessionTicketStore.RenewAsync ignores ServerSideSessions.UserDisplayNameClaimType

2 participants