Repository navigation
fix: incorrect display name value used when session ticket is renewed - #182
Merged
Merged
Conversation
patchandthat
approved these changes
Nov 16, 2026
…cting auth ticket in ticket store
jhbritton-RSK
force-pushed
the
bug/#180
branch
from
November 18, 2026 15:08
4127125 to
a80885e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Session renewal ignored the server-side session setting specifying the claim to use for the display name property.
Added test cases for unprotecting auth ticket data and serialising an unprotecting payload that throws errors.
Type of change
Does this PR introduce a breaking change?
n/a
Testing
Added a unit test for each bug fixed
LLM Usage
Used to review the unit tests and store the file to look for any other possible bugs. Found an issue with unprotecting, and deserialising unprotected data not being handled correctly and throwing errors.
Other context
Closes: #180