Prevent abort listener leaks in async client requests - #1597
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, targeted, and backed by new tests that verify listener cleanup across the relevant success and failure paths.
Pull request overview
This PR tightens Client.sendRequestAsync() resource cleanup by ensuring abort/timeout listeners are removed in all completion paths (success, abort, timeout, and synchronous failures), preventing listener accumulation across repeated async requests.
Changes:
- Add explicit cleanup of
abort/timeoutlisteners insendRequestAsync()via sharedcleanup()+ named handlers. - Add tests that assert abort/timeout listeners are fully released after each request outcome (including pre-aborted signals and send/serialization failures).
File summaries
| File | Description |
|---|---|
| lib/client.js | Ensures abort/timeout listeners are consistently removed on resolve/reject to avoid listener leaks. |
| test/test-client.js | Adds coverage asserting listener cleanup across success, abort, timeout, and error scenarios. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tightens
Client.sendRequestAsync()resource cleanup by ensuring abort/timeout listeners are removed in all completion paths (success, abort, timeout, and synchronous failures), preventing listener accumulation across repeated async requests.Changes:
abort/timeoutlisteners insendRequestAsync()via sharedcleanup()+ named handlers.Fix: #1596