chore: Stop Extensions from importing FieldDropdown - #10380
Open
mikeharv wants to merge 1 commit into
Open
Conversation
mikeharv
marked this pull request as ready for review
August 28, 2026 16:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This moves
checkDropdownOptionsInTableout ofExtensionsand intoFieldDropdown.Extensionsnow includes a setter for this checker so that the field can provide its own.field_dropdown.tsnow registers the checker once at module initialization time .Subclasses likeFieldVariable,FieldGridDropdown, andFieldDependentDropdownshould not need updating.An error is thrown just in case an application somehow uses the extension without ever importing
field_dropdown.tsor installing a custom checker.Reason for Changes
The current dependency chain is problematic. As part of #1276, I expect to need to be able to value
import {BlockSvg}. The parentBlockimportsExtensions, which means there's a potential for circular dependency. Given that this checker is strictly used for dropdown fields, moving it out feels like a reasonable way around this issue.Test Coverage
Manually confirmed that tooltips are still shown and nothing is thrown. All tests continue to pass.