Fix TC-5274: Show fix patterns for all affected files

[TamarW0]

Fixes inconsistency where affected files section showed test files but fix patterns section did not.

Applied consistent filtering to both sections - now both show only C/C++ source code files, excluding test files and build configuration.

For RPM scan workflow only (C/C++ packages)

Fixes: TC-5274

[tmihalac]

PR Review — TC-5274

Nice cleanup: extracting the predicate into _is_source_code_file / _filter_to_source_code_files and applying it to both affected_files and review snippets removes the duplication and fixes the reported inconsistency. Snippet-filter behavior is preserved exactly, and the empty-result fallback is a sensible guard. A couple of things worth addressing below.

Important

• /test/ exclusion misses top-level test/ directories, and the test gives false confidence. The "/test/" in file_path check requires a leading slash, so a top-level test/foo.c (exactly how OpenSSL lays out its C test suite) is not matched, ends with .c, and is classified as source. The added assertion _is_source_code_file("test/recipes/80-test_cms.t") is False passes only because .t isn't a source extension — the /test/ branch is never actually exercised. A path like test/bad_dtls_frag.c would slip through. Consider file_path.startswith("test/") or "/test/" in file_path, plus a test with a top-level test/*.c path. (See inline comment.)

Suggestions

• Test coverage gaps: no cases for CMakeLists/Makefile exclusion, .cpp/.cc/.cxx extensions, a top-level test/*.c file, or the empty-result fallback (_filter_to_source_code_files returning the original list). The fallback is behaviorally important — if it regresses, reports could silently go empty — yet it's untested. Prefer plain assert-based pytest style over the trailing print(...), and avoid the sys.path.insert mutation (it leaks into other tests) if a normal import / conftest.py can be used.

[tmihalac]

"/test/" in file_path requires a leading slash, so a top-level test/*.c (e.g. OpenSSL's test/foo.c) is not excluded — it ends with .c and is treated as source, contradicting the "excluding test files" intent. Suggest if file_path.startswith("test/") or "/test/" in file_path: and add a test covering a top-level test/*.c path (the current .t assertion passes on extension, not on this branch).