fix: bump aiohttp to 3.14.3 for CVE-2026-69244 - #351
Open
heatherzh01 wants to merge 1 commit into
Open
heatherzh01 wants to merge 1 commit into
heatherzh01 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aiohttpto>=3.14.3(locked at 3.14.3) to fix CVE-2026-69244: OOB heap read in the C response parser when building an error message for a malformed HTTP response. An attacker-controlled (or accidentally malformed) server could DoS the client. There is no backport; 3.14.3 is the only fix.tests/test_serp_api_key_rotation.pyto stubaiohttp.ClientSession.getwith a fake async context manager.aioresponses(through 0.7.9) still constructsClientResponsewithout the 3.14-requiredstream_writerkwarg, so it raisesTypeErrorinside the mock before our rotation logic runs (aioresponses#289). This is test-tooling lag, not a product bug —test_concurrent_rotation(no aiohttp) already passed.aioresponsesfrom the dev dependency group.Notes for reviewers
The production change is the pin only. The test file change is required to keep coverage after the bump; we are not changing SerpAPI rotation behavior.