Skip to content

fix: bump aiohttp to 3.14.3 for CVE-2026-69244 - #351

Open
heatherzh01 wants to merge 1 commit into
mainfrom
fix/CVE-2026-69244-aiohttp
Open

heatherzh01 wants to merge 1 commit into
mainfrom
fix/CVE-2026-69244-aiohttp

Conversation

@heatherzh01

Copy link
Copy Markdown

Summary

  • Bump aiohttp to >=3.14.3 (locked at 3.14.3) to fix CVE-2026-69244: OOB heap read in the C response parser when building an error message for a malformed HTTP response. An attacker-controlled (or accidentally malformed) server could DoS the client. There is no backport; 3.14.3 is the only fix.
  • Rewrite tests/test_serp_api_key_rotation.py to stub aiohttp.ClientSession.get with a fake async context manager. aioresponses (through 0.7.9) still constructs ClientResponse without the 3.14-required stream_writer kwarg, so it raises TypeError inside the mock before our rotation logic runs (aioresponses#289). This is test-tooling lag, not a product bug — test_concurrent_rotation (no aiohttp) already passed.
  • Remove unused aioresponses from the dev dependency group.

Notes for reviewers

The production change is the pin only. The test file change is required to keep coverage after the bump; we are not changing SerpAPI rotation behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant