ci: run the Netlify CLI on Node 24 - #1060
Merged
Merged
Conversation
The preview job's setup-node step pinned node-version '20'. Node 20 reached end-of-life on 2026-04-30, and netlify-cli 27.0.0 (2026-07-24) raised its engine floor to Node >=22.13.0, so the preview deploy has been installing netlify-cli@latest outside its supported range (npm logs EBADENGINE). Node here runs only the Netlify CLI inside quantecon/actions/preview-netlify. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a single, correctly-indented workflow update that aligns CI’s Node runtime with Netlify CLI’s supported engine range.
Pull request overview
Updates the GitHub Actions CI workflow to use Node.js 24 for the Netlify preview deploy, aligning the workflow runtime with the current Netlify CLI engine requirements and avoiding EBADENGINE warnings.
Changes:
- Bump
actions/setup-node@v7node-versionin the preview deploy job from'20'to'24'.
File summaries
| File | Description |
|---|---|
| .github/workflows/ci.yml | Updates the Node.js version used for the Netlify preview deploy step to Node 24. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
📖 Netlify Preview Ready!Preview URL: https://pr-1060--sunny-cactus-210e3e.netlify.app Commit: Build Info
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preview job in
ci.ymlsets up Node 20 for the Netlify deploy. This PR moves it to Node 24, which is the active LTS line. Node 20 reached end-of-life on 2026-04-30.Node runs only the Netlify CLI here, which
quantecon/actions/preview-netlifyinstalls withnpm install -g netlify-cli@latest. netlify-cli 27.0.0 (released 2026-07-24) raised its engine floor to Node>=22.13.0, and the current release (27.8.0) keeps it. So the preview deploy has been installing the CLI outside its supported range since late July. A recent preview run shows it: run 35283257505 on 2026-09-17 loggednpm warn EBADENGINEfornetlify-cli@27.8.0(required>=22.13.0, currentv20.20.2), and for several@netlify/*dependencies. npm warns but installs anyway, so the deploys have kept working.node-versionforactions/setup-node@v7(ci.yml, Setup Node.js)'20''24'actions/setup-node@v7quantecon/actions/preview-netlify@v0actions/github-script@v9(node24)No
uses:line changes. This is one line in one file.What CI proves. This PR's own CI runs the changed workflow:
ci.ymlruns onpull_request, and because this branch is in the same repository and not from Dependabot, the Install Netlify CLI and Deploy to Netlify steps run on Node 24. The warnings should be gone from that step's log. Nothing is left to prove after merge, because no other workflow uses Node.This is part of the Node 24 upgrade across the lecture and theme fleets, approved on 2026-09-18.
🤖 Generated with Claude Code