feat: add Q7 dock state enums - #958
Merged
Merged
Conversation
allenporter
approved these changes
Sep 13, 2026
Contributor
|
@akj nice improvement, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Q7 dock activity and dust collection are exposed as raw integers. This follow-up to #921 gives consumers named
idleandcollecting_duststates using the Q7 M5+ capture evidence:station_act=3anddust_action=1during emptying, both zero when idle.Both fields use
RoborockEnum, preserving numeric serialization for known states. Unrecognized codes resolve tounknown = -1, and missing values remainNone.Tests cover known and unknown codes, missing values, both key naming styles, numeric serialization, and the mocked Q7 query path.
CI passed: all 1,033 tests on Python 3.11 and 3.14, lint, commit-message validation, package build, and semantic-release checks.
The state values come from previously captured hardware runs. No new live device test was performed for this change.