fix(typing): Improve typing and other related issues in `state.py` by ToothyDev · Pull Request #3435 · Pycord-Development/pycord

ToothyDev · 2026-11-07T00:02:06Z

Summary

Just a best-effort attempt at trying to improve typing in this file. Goal is to improve, not fix everything, that would need way too many changes across too many files.
Method of the madness: Installed basedpyright, then just went from the top to the bottom of the file

Information

This PR fixes an issue.
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed).
This PR is not a code change (e.g. documentation, README, typehinting,
examples, ...).

Checklist

I have searched the open pull requests for duplicates.
If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
If type: ignore comments were used, a comment is also left explaining why.
I have updated the changelog to include these changes.
I have read the Contributing Guidelines.
AI Usage has been disclosed. -> None
- If AI has been used, I understand fully what the code does

pycord-app · 2026-11-07T00:02:12Z

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3435/head:pr-3435
git checkout pr-3435

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3435/head

First rough sweep up to line 1350 fixing what I could

ToothyDev · 2026-11-07T14:00:15Z

For context, I'm trying to stay in state.py, but if minor type additions in other files fix an issue, I will of course do so. Just to explain why I touched other files too

ToothyDev · 2026-11-08T19:26:49Z

I've done my best and killed over 200 type errors, with a sad 396 left. There are many things that are definitely too complex for me / requiring better lib knowledge, as well as a couple of things we seem to lack data dicts for. You'll see those for yourself if you run basedpyright over this horrible file.
Feel free to be critical as I basically just went through with the intention of "remove red squiggly line" as my primary goal

plun1331

i know its not in the pr but:
state 786 has a typing error (and probably just doesn't work at all)
1246 is mad about something
overload for request_guild_channel_info needs to be fixed to include a default

probably a few other things

plun1331 · 2026-11-12T00:11:16Z

-    def parse_guild_member_remove(self, data) -> None:
+    def parse_guild_member_remove(self, data: MemberRemoveEventPayload) -> None:
        user = self.store_user(data["user"])
        raw = RawMemberRemoveEvent(data, user)


change the type for this to also include member

If I change it in RawMemberRemoveEvent i get all sorts of new errors in that file, not doing that in this PR

plun1331 · 2026-11-12T00:12:48Z

@@ -1680,6 +1786,8 @@ def parse_guild_audit_log_entry_create(self, data) -> None:
        payload = RawAuditLogEntryEvent(data)
        payload.guild = guild


probably make guild a possible attr on this event

Added it only to its slots, ig thats enough

plun1331 · 2026-11-12T00:14:15Z

-            else guild.get_member(data.get("creator_id"))
-        )
+        creator = None
+        if data.get("creator"):


typeddict is wrong here, creator is NotRequired

(A TypedDict with 5 required fields is always truthy: Inferred type User is always truthytyredundant-condition)

ToothyDev · 2026-11-12T09:55:47Z

Addressed all comments, only resolved the ones I felt confident in, please check yourself what you consider resolved

Paillat-dev · 2026-11-14T21:24:15Z

278:65 error [reportArgumentType] Argument of type "ChannelFlags | Any | int" cannot be assigned to parameter "value" of type "int" in function "_from_value" Type "ChannelFlags | Any | int" is not assignable to type "int" "ChannelFlags" is not assignable to "int"

New issue in this file

@Paillat-dev Flags are a GIGANTIC mess imho, the built-in class seems to confuse the typechecker hella and the lib can't agree on whether to type them as ints or xFlag classes

Paillat-dev · 2026-11-14T21:28:21Z

                        )
                    )
-            member, before, after = guild._update_voice_state(data, channel_id)  # type: ignore
+            if not isinstance(channel_id, int):


When someone leaves voice, channel_id IS None so this should most likely not return early

Paillat-dev · 2026-11-14T21:30:42Z

            self._stickers.pop(emoji.id, None)
        # guild won't be None here
        guild.stickers = tuple(
            map(lambda d: self.store_sticker(guild, d), data["stickers"])


1614:57 error [reportGeneralTypeIssues] Could not access item in TypedDict "stickers" is not a defined key in "GuildSticker"

P sure your typing above is not right, for data.

Paillat-dev · 2026-11-14T21:32:24Z

+    def _add_reaction(
+        self,
+        data: ReactionPayload,
+        emoji: PartialEmoji | GuildEmoji | AppEmoji | str | None,
+        user_id: int,
+    ) -> Reaction:


This causes a new issue in state.py:

1027:46 error [reportArgumentType] Argument of type "ReactionActionEvent" cannot be assigned to parameter "data" of type "Reaction" in function "_add_reaction" "count" is missing from "ReactionActionEvent" "me" is missing from "ReactionActionEvent" "me_burst" is missing from "ReactionActionEvent" "count_details" is missing from "ReactionActionEvent"

Paillat-dev · 2026-11-14T21:35:11Z

+    def store_emoji(self, guild: Guild, data: EmojiPayload) -> GuildEmoji | None:
        # the id will be present here
-        emoji_id = int(data["id"])  # type: ignore
+        if data["id"] is None:
+            _log.warning("Received emoji without id")
+            return None
+        emoji_id = int(data["id"])
        self._emojis[emoji_id] = emoji = GuildEmoji(guild=guild, state=self, data=data)
        return emoji


Causing new issues in multiple files:
guild.py:

615:47 error [reportAttributeAccessIssue] Cannot assign to attribute "emojis" for class "Guild*" "tuple[GuildEmoji | None, ...]" is not assignable to "tuple[GuildEmoji, ...]" Tuple entry 1 is incorrect type Type "GuildEmoji | None" is not assignable to type "GuildEmoji" "None" is not assignable to "GuildEmoji" 3295:16 error [reportReturnType] Type "GuildEmoji | None" is not assignable to return type "GuildEmoji" Type "GuildEmoji | None" is not assignable to type "GuildEmoji" "None" is not assignable to "GuildEmoji"

state.py

1594:24 error [reportAttributeAccessIssue] Cannot assign to attribute "emojis" for class "Guild" "tuple[GuildEmoji | None, ...]" is not assignable to "tuple[GuildEmoji, ...]" Tuple entry 1 is incorrect type Type "GuildEmoji | None" is not assignable to type "GuildEmoji" "None" is not assignable to "GuildEmoji"

Paillat-dev · 2026-11-14T21:37:24Z

+    def get_reaction_emoji(
+        self, data: PartialEmojiPayload
+    ) -> GuildEmoji | AppEmoji | PartialEmoji | str | None:
        emoji_id = utils._get_as_snowflake(data, "id")


This causes a new issue in reaction.py

106:66 error [reportAttributeAccessIssue] Cannot assign to attribute "emoji" for class "Reaction*" Type "PartialEmoji | GuildEmoji | AppEmoji | str | None" is not assignable to type "PartialEmoji | GuildEmoji | AppEmoji | str" Type "None" is not assignable to type "PartialEmoji | GuildEmoji | AppEmoji | str" "None" is not assignable to "PartialEmoji" "None" is not assignable to "GuildEmoji" "None" is not assignable to "AppEmoji" "None" is not assignable to "str"

The beginning of an odyssey to fix state.py typing

56ddf3e

ToothyDev assigned ToothyDev and Paillat-dev Nov 7, 2026

ToothyDev added help wanted Extra attention is needed typing Is related to / changes python typing labels Nov 7, 2026

github-project-automation Bot added this to Pycord Nov 7, 2026

github-project-automation Bot moved this to Todo in Pycord Nov 7, 2026

fix imports up

8462af1

Paillat-dev reviewed Nov 7, 2026

View reviewed changes

Comment thread discord/state.py Resolved

Paillat-dev reviewed Nov 7, 2026

View reviewed changes

Comment thread discord/state.py Resolved

Paillat-dev reviewed Nov 7, 2026

View reviewed changes

Comment thread discord/state.py Resolved

ToothyDev added 2 commits November 7, 2026 13:28

Fix imports and undo changes

9ed432c

Work-in-Progress #1

60684d5

First rough sweep up to line 1350 fixing what I could

fix CI

61fe9d9

Paillat-dev reviewed Nov 8, 2026

View reviewed changes

Comment thread discord/state.py Resolved

ToothyDev added 3 commits November 8, 2026 17:47

Work-in-Progress changes 2

f045395

fix ci 2

2c3c4b6

Remainder of first file sweep

432e1b0

ToothyDev requested review from Paillat-dev and Soheab November 8, 2026 19:25

A few more fixes

71ab0a9

plun1331 requested changes Nov 12, 2026

View reviewed changes

Address code review change requests

8f99ac1

ToothyDev requested a review from plun1331 November 12, 2026 09:55

ToothyDev and others added 2 commits November 12, 2026 11:09

Address code review changes 2

1d9ed3b

Merge branch 'master' into fix/typing-statepy

b7c9cf1

Remove extra import

e279912

Paillat-dev reviewed Nov 14, 2026

View reviewed changes

Paillat-dev requested changes Nov 14, 2026

View reviewed changes

		@@ -1680,6 +1786,8 @@ def parse_guild_audit_log_entry_create(self, data) -> None:
		payload = RawAuditLogEntryEvent(data)
		payload.guild = guild

Conversation

ToothyDev commented Nov 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Information

Checklist

Uh oh!

pycord-app Bot commented Nov 7, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ToothyDev commented Nov 7, 2026

Uh oh!

Uh oh!

ToothyDev commented Nov 8, 2026

Uh oh!

plun1331 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ToothyDev commented Nov 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ToothyDev commented Nov 7, 2026 •

edited

Loading