Skip to content

fix: Make User | Member option types map to SlashCommandOptionType.user - #3425

Open
ToothyDev wants to merge 9 commits into
masterfrom
fix/member-user-option-type
Open

ToothyDev wants to merge 9 commits into
masterfrom
fix/member-user-option-type

Conversation

@ToothyDev

Copy link
Copy Markdown
Contributor

Summary

See title and #3423

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.
  • I have read the Contributing Guidelines.
  • AI Usage has been disclosed. -> no AI usage
    • If AI has been used, I understand fully what the code does

Fixes #3423

@ToothyDev
ToothyDev requested a review from a team November 3, 2026 18:37
@ToothyDev ToothyDev added the bug Something isn't working label Nov 3, 2026
@ToothyDev
ToothyDev requested review from a team November 3, 2026 18:37
@github-project-automation github-project-automation Bot moved this to Todo in Pycord Nov 3, 2026
@ToothyDev
ToothyDev requested a review from Lulalaby November 3, 2026 18:38
@pycord-app

pycord-app Bot commented Nov 3, 2026

Copy link
Copy Markdown

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3425/head:pr-3425
git checkout pr-3425

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3425/head

@ToothyDev
ToothyDev requested a review from a team as a code owner November 3, 2026 18:38
@ToothyDev
ToothyDev requested review from a team and JustaSqu1d November 3, 2026 18:38
@ToothyDev ToothyDev moved this from Todo to In Progress in Pycord Nov 3, 2026
@ToothyDev

Copy link
Copy Markdown
Contributor Author

Inspired by #3424 lol

@Paillat-dev Paillat-dev added this to the 2.9.0 milestone Nov 3, 2026
@ToothyDev ToothyDev changed the title fix: Make User | Member option types map to SlashCommandOptionType.user fix: Make User | Member option types map to SlashCommandOptionType.user Nov 3, 2026
Comment thread CHANGELOG.md Resolved
@Paillat-dev
Paillat-dev self-requested a review November 3, 2026 18:40
Comment thread CHANGELOG.md Resolved
Co-authored-by: Paillat <paillat@pycord.dev>
Signed-off-by: ToothyDev <55001472+ToothyDev@users.noreply.github.com>
@ToothyDev
ToothyDev requested a review from Paillat-dev November 6, 2026 23:56
Comment thread discord/enums.py Resolved
@ToothyDev
ToothyDev requested a review from plun1331 November 8, 2026 20:47
plun1331
plun1331 previously approved these changes Nov 8, 2026
…tax (#3407)

* Update old None-types to use correct syntax

This will make None clickable in the docs and lead to the python docs

* Documentation changes

* Code changes

* Fix up extra space

* Apply change requests and fix docs

* Apply change requests

Co-authored-by: Michael <8661717+sgtlaggy@users.noreply.github.com>

* Update new leftover Optionals use

* Update old :data:None to use obj:None style

Napoleon seems to internally use this style as well, so I'm choosing it over the existing :data: type

---------

Co-authored-by: Michael <8661717+sgtlaggy@users.noreply.github.com>
Paillat-dev
Paillat-dev previously approved these changes Nov 10, 2026
@Paillat-dev
Paillat-dev disabled auto-merge November 10, 2026 18:36
plun1331
plun1331 previously approved these changes Nov 10, 2026
@Paillat-dev
Paillat-dev dismissed stale reviews from plun1331 and themself November 10, 2026 21:47

The merge-base changed after approval.

@Paillat-dev
Paillat-dev requested a review from a team as a code owner November 10, 2026 21:47
@Paillat-dev
Paillat-dev requested review from a team and NeloBlivion November 10, 2026 21:47
Signed-off-by: Paillat <paillat@pycord.dev>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Member | User maps to SlashCommandOptionType.mentionable

3 participants