Skip to content

fix(ui): use correct keys when removing views from the store - #3360

Open
vmphase wants to merge 17 commits into
masterfrom
fix/viewstore-removeitem
Open

vmphase wants to merge 17 commits into
masterfrom
fix/viewstore-removeitem

Conversation

@vmphase

@vmphase vmphase commented Aug 21, 2026

Copy link
Copy Markdown
Member

Summary

Fixes a regression introduced in #2904, where ViewStore._views keys were changed from 2-tuples (component_type, custom_id) to 3-tuples (component_type, message_id, custom_id).

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.
  • I have read the Contributing Guidelines.
  • AI Usage has been disclosed.
    • If AI has been used, I understand fully what the code does

@vmphase
vmphase requested review from a team, Lulalaby and plun1331 August 21, 2026 10:31
@vmphase
vmphase requested a review from a team as a code owner August 21, 2026 10:31
@github-project-automation github-project-automation Bot moved this to Todo in Pycord Aug 21, 2026
@pycord-app

pycord-app Bot commented Aug 21, 2026

Copy link
Copy Markdown

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3360/head:pr-3360
git checkout pr-3360

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3360/head

@Paillat-dev
Paillat-dev requested review from a team and NeloBlivion and removed request for a team August 21, 2026 10:32
@vmphase
vmphase requested a review from a team as a code owner August 21, 2026 10:43
@vmphase
vmphase requested review from a team and JustaSqu1d August 21, 2026 10:43
Paillat-dev
Paillat-dev previously approved these changes Nov 2, 2026
@Paillat-dev

Copy link
Copy Markdown
Member

@NeloBlivion Can you take a look when you got a sec pls ? Thankies :3

Signed-off-by: Michael <vmphase.dev@gmail.com>
@vmphase
vmphase requested a review from Paillat-dev November 11, 2026 15:27
Paillat-dev
Paillat-dev previously approved these changes Nov 12, 2026
Comment thread CHANGELOG.md Resolved
Signed-off-by: plun1331 <plun@plunthe.dev>
@plun1331
plun1331 requested a review from Paillat-dev November 12, 2026 23:40

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

4 participants