Conversation
TestFirmwareVersionConsistent compares firmware versions from the ioctl path against the debugfs amdgpu_firmware_info file. On RDNA4 (and other cards or kernels) that debugfs file is empty or cannot be opened, so the debugfs side reads zero and the test fails on real hardware. Skip the consistency check when the debugfs firmware info is unavailable, leaving the ioctl path covered elsewhere. Fixes #36 Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
|
@moezdil: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: moezdil The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
/kind bug
TestFirmwareVersionConsistent fails on real RDNA4 hardware and in CI because the debugfs amdgpu_firmware_info file is empty or unreadable. Skip the ioctl/debugfs consistency check when debugfs firmware info is unavailable.
Fixes #36