FOUR-32144: Improve the api PUT /api/1.0/tasks/{task-id} by pmPaulis · Pull Request #9045 · ProcessMaker/processmaker

pmPaulis · 2026-09-08T14:56:31Z

Improve the api PUT /api/1.0/tasks/{task-id}

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-32635

Code Review Checklist

I have pulled this code locally and tested it on my instance, along with any associated packages.
This code adheres to ProcessMaker Coding Guidelines.
This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
This solution fixes the bug reported in the original ticket.
This solution does not alter the expected output of a component in a way that would break existing Processes.
This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy

Introduce PUT /api/1.1/tasks/{id} for COMPLETED status, gated by TASK_UPDATE_V1_1_ENABLED, with optional raw token persistence behind TOKEN_PERSISTENCE_RAW_ENABLED. https://processmaker.atlassian.net/browse/FOUR-32800

…is executed.

https://processmaker.atlassian.net/browse/FOUR-32800

feat(FOUR-32801): improve Jobs execution when the PUT tasks endpoint is executed

feat(FOUR-32800): add v1.1 task completion endpoint with raw SQL path

cursor · 2026-09-08T14:56:48Z

PR Summary

High Risk
Changes core BPMN task completion and persistence paths behind feature flags; misconfiguration or raw-SQL drift from Eloquent behavior could affect workflow data integrity and authorization.

Overview
Adds an opt-in fast path for completing tasks via PUT /api/1.1/tasks/{id} (flags TASK_UPDATE_V1_1_ENABLED / TOKEN_PERSISTENCE_RAW_ENABLED, both default off). The endpoint only accepts status: COMPLETED; other updates still go through API 1.0.

Completion uses raw SQL reads (TaskCompletionRawRepository), authorization on lightly hydrated models (TaskCompletionEngineBridge), sanitized payload data, then WorkflowManager::completeTask. When raw persistence is enabled, TokenRepository and ExecutionInstanceRepository write token and request instance changes through TokenPersistenceRawRepository instead of full Eloquent saves.

Indexed search: ProcessRequest and ProcessRequestToken gain wasSearchableBeforeUpdate / wasSearchableBeforeDelete so Scout does not queue RemoveFromSearch when indexed search is disabled.

Queue: GenerateUserRecommendations implements ShouldBeUnique per user (60s) to collapse duplicate dispatches from Smart Inbox / activity events.

^{Reviewed by Cursor Bugbot for commit daafb12. Bugbot is set up for automated code reviews on this repo. Configure here.}

cursor

Cursor Bugbot has reviewed your changes using high effort and found 5 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 5e7ca61. Configure here.}

cursor · 2026-09-08T15:03:09Z

+            'completed_at',
+            'token_properties',
+        ]);
+    }


Raw save skips completion timestamp

High Severity

Raw token updates skip ProcessRequestTokenObserver, so completed_at_ms is never set. After persist, BpmnSubscriber calls diffInMilliseconds on that null value and task completion fails whenever token_persistence_raw_enabled is on.

Additional Locations (1)

ProcessMaker/Repositories/TokenRepository.php#L727-L743

^{Reviewed by Cursor Bugbot for commit 5e7ca61. Configure here.}

cursor · 2026-09-08T15:03:09Z

+            if (array_key_exists($field, $instance->getDirty())) {
+                $payload[$field] = $instance->getAttributes()[$field];
+            }
+        }


Raw persist drops signal events

High Severity

The raw persistInstanceUpdated path only writes status, last_stage_id, last_stage_name, progress, and completed_at. signal_events from updateCatchEvents never reaches the database, so signal and boundary catch events can miss incoming signals.

Additional Locations (1)

ProcessMaker/Repositories/ExecutionInstanceRepository.php#L239-L248

^{Reviewed by Cursor Bugbot for commit 5e7ca61. Configure here.}

cursor · 2026-09-08T15:03:09Z

+
+        $this->runUpdate('process_requests', (int) $instance->getKey(), $payload);
+        $instance->syncChanges();
+    }


Raw persist skips case title

Medium Severity

Raw instance updates skip ProcessRequestObserver::saving, so case_title and case_title_formatted are not recomputed when request data changes. Inbox and case lists keep stale titles until a later Eloquent save.

Additional Locations (1)

ProcessMaker/Repositories/ExecutionInstanceRepository.php#L239-L248

^{Reviewed by Cursor Bugbot for commit 5e7ca61. Configure here.}

cursor · 2026-09-08T15:03:09Z

+            'data',
+            'token_properties',
+        ]);
+    }


Raw save leaves scheduled tasks

High Severity

Closing or completing a token via raw SQL never runs ProcessRequestTokenObserver::saved, so timer scheduledTasks for that token are not deleted and can still fire after the activity is done.

Additional Locations (1)

ProcessMaker/Repositories/TokenPersistenceRawRepository.php#L40-L50

^{Reviewed by Cursor Bugbot for commit 5e7ca61. Configure here.}

cursor · 2026-09-08T15:03:09Z

+
+        $this->runUpdate('process_request_tokens', $tokenId, $payload);
+        $token->syncChanges();
+    }


Raw persist skips search indexing

Medium Severity

Raw SQL updates do not fire Scout saved hooks. When indexed search is enabled, ProcessRequest and ProcessRequestToken documents are not updated after completion, so search results go stale.

Additional Locations (1)

ProcessMaker/Repositories/TokenPersistenceRawRepository.php#L71-L105

^{Reviewed by Cursor Bugbot for commit 5e7ca61. Configure here.}

nolanpro · 2026-09-08T15:34:29Z

QA server K8S was successfully deployed https://ci-eaf6871c59.engk8s.processmaker.net

FOUR-32800: test compares legacy and optimized

decisions-sonarqube · 2026-09-08T21:24:20Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

nolanpro · 2026-09-08T21:59:40Z

QA server K8S was successfully deployed https://ci-eaf6871c59.engk8s.processmaker.net

gproly and others added 7 commits August 28, 2026 08:20

feat(FOUR-32801): improve Jobs execution when the PUT tasks endpoint …

6795511

…is executed.

style(FOUR-32800): reorder imports in task completion raw service files

3fc16e0

https://processmaker.atlassian.net/browse/FOUR-32800

Merge branch 'develop' into feature/FOUR-32800

b55a89c

FOUR-32800: test compares legacy and optimized

a5f315b

Merge pull request #9021 from ProcessMaker/bugfix/FOUR-32801

da5e64f

feat(FOUR-32801): improve Jobs execution when the PUT tasks endpoint is executed

Merge pull request #9020 from ProcessMaker/feature/FOUR-32800

5e7ca61

feat(FOUR-32800): add v1.1 task completion endpoint with raw SQL path

pmPaulis added the performance label Sep 8, 2026

cursor Bot reviewed Sep 8, 2026

View reviewed changes

pmPaulis and others added 2 commits September 8, 2026 14:32

feat(FOUR-32800): solving observation about starts

c2ea6f6

Merge pull request #9046 from ProcessMaker/feature/FOUR-32800

daafb12

FOUR-32800: test compares legacy and optimized

Navigation Menu

Uh oh!

FOUR-32144: Improve the api PUT /api/1.0/tasks/{task-id} - #9045

FOUR-32144: Improve the api PUT /api/1.0/tasks/{task-id}#9045
pmPaulis wants to merge 9 commits into
developfrom
task/FOUR-32144

pmPaulis commented Sep 8, 2026

Uh oh!

cursor Bot commented Sep 8, 2026 •

edited

Loading

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot Sep 8, 2026

Uh oh!

cursor Bot Sep 8, 2026

Uh oh!

cursor Bot Sep 8, 2026

Uh oh!

cursor Bot Sep 8, 2026

Uh oh!

cursor Bot Sep 8, 2026

Uh oh!

nolanpro commented Sep 8, 2026

Uh oh!

decisions-sonarqube Bot commented Sep 8, 2026

Uh oh!

nolanpro commented Sep 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

pmPaulis commented Sep 8, 2026

Improve the api PUT /api/1.0/tasks/{task-id}

Related Tickets & Packages

Code Review Checklist

Uh oh!

cursor Bot commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Sep 8, 2026

Choose a reason for hiding this comment

Raw save skips completion timestamp

Uh oh!

cursor Bot Sep 8, 2026

Choose a reason for hiding this comment

Raw persist drops signal events

Uh oh!

cursor Bot Sep 8, 2026

Choose a reason for hiding this comment

Raw persist skips case title

Uh oh!

cursor Bot Sep 8, 2026

Choose a reason for hiding this comment

Raw save leaves scheduled tasks

Uh oh!

cursor Bot Sep 8, 2026

Choose a reason for hiding this comment

Raw persist skips search indexing

Uh oh!

nolanpro commented Sep 8, 2026

Uh oh!

decisions-sonarqube Bot commented Sep 8, 2026

Quality Gate passed

Uh oh!

nolanpro commented Sep 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cursor Bot commented Sep 8, 2026 •

edited

Loading