Repository navigation
Devices: native removal of ghost (non-present) devices - #36
Merged
Merged
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Adds "Remove ghost devices" to the Devices page. It lists every non-present device (except ones TweakHub disabled, which stay tracked for "Re-enable all"), ticks hardware ghosts and leaves software-enumerated ones (ROOT, SWD, SW, UMB, HTREE, GUID buses) unticked. One elevated script re-reads DEVPKEY_Device_IsPresent before each `pnputil /remove-device`, so a device plugged in meanwhile is skipped; the result dialog shows removed and not-removed devices, then the list refreshes. The dialog states that removal cannot be undone from TweakHub. The choice list in AppDialog now scrolls and wraps, so long lists keep the buttons on screen. Closes #35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35.
What changes
pnputil /remove-device, through the existing elevated, hash-approved script flow.Present = falsedevices are listed; present devices are never touched;ROOT\,SWD\,SW\,UMB\,HTREE\,{GUID}buses) are listed but not ticked, because some are hidden on purpose and still needed.DEVPKEY_Device_IsPresentright before each removal, so a device reconnected meanwhile is skipped (SKIP).AppDialogchoice lists now scroll (max 360 px) and wrap, so a long list (80–170 ghosts) keeps the buttons on screen.Resources/Devices*.resx).Tests
GhostRemovalListsOnlyNotPresentDevicesAndTicksOnlyHardwareOnes; the removal script was added to the PowerShell parse test.dotnet build -c Release: 0 errors, 0 warnings.dotnet test: 414/414 passed.DeviceServicemethods against the guest: 150 devices, 64 present, 86 ghosts, 82 ticked → 82 removed, 0 failed. A present device added to the list on purpose was skipped. Afterwards the guest had 64 present and 4 ghosts (the unticked software ones), and no removed device was listed byGet-PnpDevice. The VM was then restored to its clean checkpoint.