Repository navigation
test: raise the coverage to 91.0 % - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the coverage of the package from 82.1 % to 91.0 % (331 of 403 lines to 367; measured locally with PHP 8.4 and pcov, equal to the recorded ratchet 82.13), with tests only (
src/andvocabulary/are untouched).29 tests in
tests/Unit/DeclarationAttributesTest.phpfor attributes that had no direct test. Most attributes are promoted constructors, so one line each, covered as soon as they are built, which is why a small number of tests moves the figure. The tests also pin the behaviour ofAccessandBindingFieldType.36 lines still count as uncovered, all in
vocabulary/(Access,Every,Interval,BindingFieldType): pcov looks atsrc/by default, sovocabulary/is outside the measured directory but inside the denominator, althoughEveryandIntervalalready had passing tests. With-d pcov.directory=.the total would be about 100 % (deduced, not run). Everything undersrc/is at 100 %.rectorhas no configuration in this package, so it was not run. The ratchet in.harness.jsongoes from 82.13 to 91. 362 tests pass (1 skipped, as before) in random orders; Pint, PHPStan andtests/Arch.phpare clean.