feat: add bounded structure-aware Behavior Tree XML diff - #31
Draft
picknik-johnny-5-bot[bot] wants to merge 7 commits into
Draft
picknik-johnny-5-bot[bot] wants to merge 7 commits into
picknik-johnny-5-bot[bot] wants to merge 7 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[written by AI]
Related to PickNikRobotics/moveit_pro#21717
Summary
BT::RenderXMLDiffas an installed C++17 library API with deterministic Markdown and plain-text output. It distinguishes moved, modified, added, and removed BT content, including wrapper insertions.Validation
git diff --checkpassed.Scope and remaining work
PostConditions.Issue601intermittently asserts in the timer queue. The same test also intermittently failed in the unchanged base and prior candidate sanitizer builds. Focused sanitizer tests for the changed XML-diff path pass. Leak detection was disabled for the focused run because of a separate pre-existing leak.CI and review status at
aa671ad574505616d1e86d4164a72decce8983ecReactive.MissingOrEmptyGenericChildIdIsRejectedtest fails with SEH 0xc0000005. The same test failed in the earlierfix/22500-reactive-generic-childrenrun on September 10, before this PR: https://github.com/PickNikRobotics/BehaviorTree.CPP/actions/runs/34393607502. Current failing run: https://github.com/PickNikRobotics/BehaviorTree.CPP/actions/runs/36072102339. This does not establish that the whole Windows job is healthy; a separate baseline fix or explicit exception is needed.