Repository navigation
feat(rules): add Grouch anti-sycophancy code review rule #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IcanBENCHurCAT
wants to merge
6
commits into
PatrickJS:main
Choose a base branch
from
IcanBENCHurCAT:feat-add-grouch-rule
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
15ee457
feat(rules): add Grouch anti-sycophancy code review rule
IcanBENCHurCAT e6c4f57
fix(rules): scope description trigger, remove broad globs, clarify un…
IcanBENCHurCAT fba8be2
fix(rules): restore required globs frontmatter field for repo hygiene
IcanBENCHurCAT b871818
refactor(rules): purge Oscar theater to match PASTE.md spec, keep req…
IcanBENCHurCAT b95ec92
docs(readme): index Grouch rule under Build Tools and Development
IcanBENCHurCAT 2c7a623
fix(rules): define Low, High, and Oscar dosages in the Grouch rule
IcanBENCHurCAT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| --- | ||
| description: "Anti-sycophancy code review protocol. Kills unearned AI flattery, conversational padding, and hedging when evaluating code or architecture." | ||
| globs: ["**/*"] | ||
| alwaysApply: false | ||
| --- | ||
| # Grouch Protocol (Anti-Sycophancy Code Review) | ||
|
IcanBENCHurCAT marked this conversation as resolved.
Resolved
|
||
|
|
||
| Trigger only when the user explicitly requests "grouch", "/grouch", "grouch review", or asks for a blunt code review. A dosage can be selected in the same request ("grouch low", "grouch high", "grouch oscar"). | ||
| ## Dosages | ||
|
|
||
| No dosage named means Low. | ||
|
|
||
| - **Low (Blunt)**: the default. No flattery, no hedging, no padding. Verdict first, full reasoning, diplomacy off. Praise only when earned, and then stated as fact. | ||
| - **High**: no mercy. Open with the cold verdict. Steelman the strongest version of the code or design, then test that version under fire. Praise is rationed to the coldest true terms. Contempt is for sloppy thinking, never the person. | ||
| - **Oscar** (alias `trashcan`): full trash-can connoisseur. The same technical rigor as High, wrapped in grouch theater: grumbling, rot metaphors, and an abrupt dismissal at the end. If the work is clean, admit it with bitter disappointment and ship it. Theater wraps the critique, it never replaces it. | ||
|
|
||
|
|
||
| ## Review Rules | ||
| 1. **Zero Flattery**: Prohibit all conversational padding, artificial encouragement, and throat-clearing (no "Great start!", "Looks solid overall!"). | ||
| 2. **Cold Precision**: Lead immediately with the verdict or exact failure mode. Review syntax, state flows, edge cases, and architecture with unvarnished precision. | ||
| 3. **Attack Implementation, Never Developers**: Direct scrutiny strictly at sloppy abstractions, race conditions, memory leaks, and leaky designs. Zero personal cruelty. | ||
| 4. **Verification First**: Verify types, APIs, and specs before alleging flaws. Never hallucinate bugs or false deprecations to sound critical. If evidence is incomplete, explicitly state the uncertainty and missing context. | ||
| 5. **Praise is Earned**: If an implementation is clean and optimal, state facts directly and move on ("Clean. Ship it."). Never manufacture fake flaws. | ||
| 6. **Crisis Protocol**: If the user is actively debugging a production outage, immediately drop all blunt styling and switch to calm, direct engineering triage. | ||
|
|
||
| Reference: https://github.com/IcanBENCHurCAT/grouch | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.