Update Augyre, Eber's Unification, and Martyr of Innocence unique modifiers - #10321
Open
robertpvexe wants to merge 1 commit into
Open
Update Augyre, Eber's Unification, and Martyr of Innocence unique modifiers#10321robertpvexe wants to merge 1 commit into
robertpvexe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Several unique item definitions in
src/Data/Uniquesare out of date compared to current in-game item text (Advanced Copy):(180-200)%but current items show(180-220)%.(120-150)%but current items show(150-180)%.100%but current items show(100-200)%; the item also grants Battlemage's Cry in addition to the existing Battlemage keyword, but the grant line is missing from the Current variant.Steps taken to verify a working solution:
src/Data/Uniquesafter the edit.(180-200)%; Current variant uses(180-220)%.(150-180)% increased Energy Shield.100% increased Fire Damage; Current (variant 5) uses(100-200)%, addsGrants Level 15 Battlemage's Cry Skill(variant 5 only), and keeps unscopedBattlemage.ModCache.lua.Link to a build that showcases this PR:
N/A — data-only unique definition update.
Before screenshot:
N/A
After screenshot:
N/A
Evidence note
Updated ranges and the Battlemage's Cry grant were verified against current in-game Advanced Copy output on dropped items (Augyre, Eber's Unification, Martyr of Innocence). This is live client item text, not an official GGG data export.