Search for items by modifier in craft item menu. - #10318
Open
AdamZ-8113 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10316
Description of the problem being solved:
When crafting an item through the crafting item menu, many item bases have implicits, enchants, or other modifiers that users would like to be able to search for. In this case, there are tons of Talismans and you might know you want one with "+1 Frenzy Charge" but you don't remember that it's a Cobra Talisman.
This PR is generalized to all item base items in the craft item menu. This can be useful when you're searching for a utility flask with
res, so that the search is narrowed to Bismuth/Ruby/Topaz/Sapphire, etc.The code here is modeled after the import character workflow which allows for searching by class or character name. We're adding support for implicits, enchants, base flasks, and base tinctures (even though they use implicits for the base item atm)
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: