Switch to standard OpenTelemetry environment variables for OTLP configuration - #5824
Merged
Conversation
johnsimons
force-pushed
the
john/otel_envvar
branch
from
August 25, 2026 00:25
6ac19eb to
9abb2a3
Compare
…guration Removes the custom OtlpEndpointUrl setting in favor of standard environment variables such as OTEL_EXPORTER_OTLP_ENDPOINT and OTEL_EXPORTER_OTLP_METRICS_ENDPOINT. This ensures compatibility with native OpenTelemetry SDK configuration, supports both gRPC and HTTP protocols, and simplifies instance configuration.
johnsimons
force-pushed
the
john/otel_envvar
branch
from
August 25, 2026 00:54
9abb2a3 to
5005697
Compare
johnsimons
changed the title
| public static class OtlpEndpoint | ||
| { | ||
| public static string MetricsEndpointFromEnvironment() => | ||
| Read("OTEL_EXPORTER_OTLP_METRICS_ENDPOINT") ?? Read("OTEL_EXPORTER_OTLP_ENDPOINT"); |
Contributor
There was a problem hiding this comment.
It looks like OTEL_EXPORTER_OTLP_METRICS_ENDPOINT isnt supported when using AddOtlpExporter - https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.17.0/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/README.md?plain=1#L520-L530
Member
Author
There was a problem hiding this comment.
I removed that and mentioned it in the docs
| } | ||
| var otlpEndpoint = OtlpEndpoint.MetricsEndpointFromEnvironment(); | ||
|
|
||
| if (!Uri.TryCreate(settings.OtlpEndpointUrl, UriKind.Absolute, out var otlpEndpoint)) |
Contributor
There was a problem hiding this comment.
Have you confirmed that the OpenTelemetry library does indeed fail an invalid URL?
Member
Author
There was a problem hiding this comment.
It now fails if the URL is invalid, so it no longer defaults.
|
|
||
| static string Read(string variable) | ||
| { | ||
| var value = Environment.GetEnvironmentVariable(variable); |
Contributor
There was a problem hiding this comment.
Should we read through IConfiguration rather direct from env var? This would provide more flexibility to the user in how they set this.
The OpenTelemetry SDK only honors signal-specific environment variables, such as OTEL_EXPORTER_OTLP_METRICS_ENDPOINT, when using UseOtlpExporter. Since instances use AddOtlpExporter to restrict OTLP to metrics, these specific variables have no effect and have been removed to avoid confusion. This also switches the endpoint detection to use IConfiguration and returns a Uri to ensure the configured value is valid.
warwickschroeder
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the custom OtlpEndpointUrl setting in favor of standard environment variables such as OTEL_EXPORTER_OTLP_ENDPOINT and OTEL_EXPORTER_OTLP_METRICS_ENDPOINT. This ensures compatibility with native OpenTelemetry SDK configuration, supports both gRPC and HTTP protocols, and simplifies instance configuration.
This came from #5816 (comment)