Skip to content

Rename _is_agrid to _is_cgrid #3059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hayatexe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename _is_agrid to _is_cgrid #3059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/parcels/_core/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ def construct_fields(self) -> list[Field | VectorField]:

for vfield_name, components in self.vector_field_components.items():
interp_method = (
XLinear_Velocity() if _is_agrid(self.data, u=components[0], v=components[1]) else CGrid_Velocity()
CGrid_Velocity() if _is_cgrid(self.data, u=components[0], v=components[1]) else XLinear_Velocity()
)

component_fields = [single_fields[name] for name in components]
Expand Down Expand Up @@ -553,10 +553,10 @@ def _select_uxinterpolator(da: ux.UxDataArray):
return None


def _is_agrid(ds: xr.Dataset, u: str, v: str) -> bool:
# check if U and V are defined on the same dimensions
# if yes, interpret as A grid
return set(ds[u].dims) == set(ds[v].dims)
def _is_cgrid(ds: xr.Dataset, u: str, v: str) -> bool:
# check if U and V are defined on different dimensions
# if yes, interpret as C grid (if no, it could be an A or B grid)
return set(ds[u].dims) != set(ds[v].dims)


def _get_time_interval(data: xr.DataArray | ux.UxDataArray) -> TimeInterval | None:
Expand Down
Loading