Repository navigation
Fixing handling singleton dimensions in NEMO - #3051
Merged
erikvansebille merged 5 commits intoNov 13, 2026
Merged
erikvansebille merged 5 commits into
erikvansebille merged 5 commits into
Conversation
erikvansebille
changed the title
erikvansebille
changed the title
wyatt-fluidnumerics
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves
convert.nemo_to_sgrid()by supporting singleton ("mock") dimensions, which were introduced after this convert-function. This means we can now also support NEMO files without time, as well as depth. This thus fixes #3050Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
Discussion about the bit on singleton z on 2D mesh_mask variables (e.g. fmask)