Repository navigation
Conversation
jeffhammond
approved these changes
Nov 9, 2026
Author
|
The red |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI has no job that builds or runs the CUDA kernels in
Cxx11/, because the hosted runners have no GPU. This adds a separate, optional workflow (.github/workflows/gpu-sim.yml) that builds them with CUDA 13.0 and runs them on a simulated NVIDIA H100 provided by PantheonSim (via thepantheongpu/setup-pantheonsimaction, pinned by SHA). I am the author of PantheonSim, so please weigh this accordingly.It is not meant to be a required check and does not replace testing on real GPUs. A simulator cannot reproduce hardware-specific behavior or timing, so I see it as a way to catch CUDA breakage in pull requests when nobody has a GPU at hand. The programs verify their own results, so a wrong answer makes the step fail.
What it does
common/make.defs.cudatocommon/make.defsand changes three things withsed:NVCCpoints at the CUDA 13.0 toolkit installed by the action,--gpu-architecture=sm_89becomescompute_90 -cudart shared(the simulator JIT-compiles PTX and needs a shared CUDA runtime), and the CUDA 12.6 include path is updated. Nothing in the repository's own files is changed.make -f Makefile.legacy:nstream-cuda,nstream-managed-cuda,transpose-cuda,stencil-cuda,p2p-cuda,nstream-device-thrust,transpose-device-thrust,nstream-cublas,transpose-cublas,dgemm-cublas,sgemm-cublas. Boost headers are installed because the thrust and cuBLAS targets include Boost.Range.vgpu runwith small sizes (19 invocations: a few variants of nstream, transpose, stencil, p2p, and one or two of the others). There is no CUDA entry in the existing test scripts, so the arguments follow each program's usage message.workflow_dispatchandpull_requesttomain, path-filtered to the CUDA, cuBLAS and thrust sources,prk_*.h,Cxx11/Makefile.legacy,common/make.defs.cudaand the workflow itself. A concurrency group cancels older runs.What was left out
*-cudastfprograms (need the CUDA STF headers fromci/install-cudastf.sh), and the MPI, NCCL, NVSHMEM and multi-GPU programs.Result on a fork
All 19 runs print "Solution validates" and the job succeeds. With a cold cache the job took about 16 minutes, almost all of it the action building the simulator the first time; building the kernels took 28 s and running them took 14 s.
Run: https://github.com/saqibkh/Kernels/actions/runs/42557389354