Skip to content

fix(types): normalize nullable array shapes - #396

Open
sidux wants to merge 1 commit into
PHPantom-dev:mainfrom
sidux:fix/nullable-array-shape-normalization
Open

fix(types): normalize nullable array shapes#396
sidux wants to merge 1 commit into
PHPantom-dev:mainfrom
sidux:fix/nullable-array-shape-normalization

Conversation

@sidux

@sidux sidux commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Why

Equivalent nullable array-shape spellings could survive as separate union members. Repeated control-flow joins then multiplied those equivalent variants, increasing type size and making workspace diagnostics progressively more expensive.

Summary

  • normalize nullable array shapes before union insertion
  • flatten and deduplicate equivalent nullable variants during joins
  • cover repeated shape merges with a regression test

Validation

  • cargo clippy --all-targets -- -D warnings
  • cargo test: 14,092 passed; 12 ignored

Treat union-with-null and nullable wrappers as the same shape during repeated branch merges.
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants