Repository navigation
feat(decisive): 决战功能拓展 #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
eb36c44
76d1887
52d2bdf
736ddcd
7698eb7
9c4d244
4432e66
7227739
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ | |
| from dataclasses import dataclass, field | ||
| from typing import TYPE_CHECKING | ||
|
|
||
| from autowsgr.constants import normalize_ship_name | ||
| from autowsgr.infra.logger import get_logger | ||
| from autowsgr.types import ShipDamageState | ||
| from autowsgr.ui.stack import UIStack | ||
|
|
@@ -136,10 +137,11 @@ def fleet(self, fleet_id: int) -> Fleet: | |
| return self.fleets[fleet_id - 1] | ||
|
|
||
| def get_ship(self, name: str) -> Ship: | ||
| """按名称获取舰船, 不存在则自动注册。""" | ||
| if name not in self.ship_registry: | ||
| self.ship_registry[name] = Ship(name=name) | ||
| return self.ship_registry[name] | ||
| """首次实见时登记舰名,同船别名共用伤情和维修记录。""" | ||
| key = normalize_ship_name(name) or name | ||
| if key not in self.ship_registry: | ||
| self.ship_registry[key] = Ship(name=key) | ||
| return self.ship_registry[key] | ||
|
|
||
| def is_ship_available(self, name: str) -> bool: | ||
| """判断舰船是否可用 (非大破 且 非修理中)。""" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 根据代码变更,发现以下潜在问题:
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
整体看,这次变更主要是对文档/注释的澄清,没有涉及可执行代码,因此没有发现运行时逻辑、性能、安全或兼容性问题。不过有几点建议:
“不用待测结果挑选模板”这一约束被弱化
原文“只有节点全部合法敌情变体中一致的舰类槽位才用于核对,不用待测结果挑选模板”强调的是:校验时模板来自资料,不能由待测识别结果反向选择。新文改成“只有这些编队在同一位置上的舰种都相同时,才核对该位置的识别结果”后,虽然保留了“一致才核对”的条件,但少了“模板不依赖待测结果”的明确说明。建议补回或合并这一语义,避免读者产生歧义。
“可观测字母”表述较模糊,且“18 份 EX YAML”是固定数量
“从 18 份 EX YAML 将真实分支投影为可观测字母”中的“可观测字母”具体指什么?如果是指决战地图的分支节点字母(如 A/B/C),建议直接写明。另外“18 份”是当前实现中的固定数量还是容易变化的配置?如果是文档描述,建议确认其准确性,或改为“对应的 EX YAML”以免未来文件数量变化导致文档过时。
“跳过该位置”与“跳过相应证据”两种表述可统一
前一句说“某个位置的舰种未知或识别为
NO时,跳过该位置”,后一句说“阵型未知或未检出迂回按钮时也跳过相应证据”。二者一个是“位置”,一个是“证据”,建议统一为比如“该位置的相应证据不参与匹配”,避免阅读时混淆。