Skip to content

fix(ui): handle decisive tabs and expedition bonus badges - #582

Merged
YaoerWu merged 2 commits into
OpenWSGR:mainfrom
YaoerWu:fix/map-tab-strip-decisive
Nov 17, 2026
Merged

YaoerWu merged 2 commits into
OpenWSGR:mainfrom
YaoerWu:fix/map-tab-strip-decisive

Conversation

@YaoerWu

@YaoerWu YaoerWu commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

活动期间,地图标签识别可能失败,远征收取也可能把「大成功 x2」长徽章误认为完成通知。本 PR 修复这两处检测。

修改

  • 地图标签栏裁剪宽度从 0.63 扩展到 0.78,地图模板扩展到 743×40,覆盖决战标签;其他页面保持原来的裁剪宽度与模板。
  • 将 fix: 修复远征大成功x2时错误识别 #286 的右侧排除探测点迁移到 v2,使用相对坐标区分「大成功 x2」长徽章与圆形远征完成通知。
  • 远征完成时圆形通知优先显示,收取后恢复长徽章;恢复显示的长徽章不再触发“通知仍在但没有就绪槽位”的 10 秒等待。原有收取流程保持不变。
  • 增加徽章识别、收取结束与入口判断的回归测试,并同步使用文档。

验证

  • pytest -q:1574 passed,25 skipped。
  • 23 项远征定向回归通过,覆盖 960×540、1280×720、1600×896;验证普通通知、长徽章,以及“圆形完成通知 → 收取 → 长徽章恢复”的过程。
  • 全量预提交检查完成。Windows 将 CLAUDE.md 和 .claude/skills 两处 Git 符号链接检出为文本占位文件,因此仅对这两个文件豁免 end-of-file-fixer;其余文件的该检查及其他全量检查均通过。
  • 此前 1280×720 实机“出征 → 决战”标签切换 5/5 成功,全程未进行战斗。

长徽章回归使用合成像素画面,第二探测点依据 #286;尚未取得该用户日志中的原始错误截图,未宣称完成原始现场复测。

决战 tab 中心 x≈0.698, 在地图页模板视野 (左侧 63%) 之外——切换到
决战 tab 后页面识别分数跌破 0.6 阈值, 面板切换超时失败。

- 地图页标签栏裁剪宽度按页参数化: 地图 0.78 (743px), 其余 0.63 (600px)
- map.png 重新生成 743x40: 左 600 列保持原模板逐字节不变, 右侧决战
  区域由实拍帧 OR 合成 (含激活/未激活文字与活动徽章, 单向覆盖度下
  徽章消失亦无影响)
- 新增回归测试锁定裁剪比例与模板宽度对应关系

Co-Authored-By: Claude Code <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Restore the OpenWSGR#286 exclusion probe omitted during the v2 migration.
Completed expeditions replace the long bonus badge with a round notice;
keep the existing collection checks and reject the restored bonus badge.

Add notification and collection regressions across three resolutions.

Refs OpenWSGR#286, OpenWSGR#582
@YaoerWu YaoerWu changed the title fix(ui): extend map tab-strip template to cover decisive tab fix(ui): handle decisive tabs and expedition bonus badges Nov 17, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review from [deepseek-v4-flash]:
- Total changes: 5
- Filtered: 5
- Reviewed: 5
- Found issues: 0

@YaoerWu
YaoerWu merged commit c4ef885 into OpenWSGR:main Nov 17, 2026
4 checks passed
@YaoerWu
YaoerWu deleted the fix/map-tab-strip-decisive branch November 17, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant