Repository navigation
feat: allow talking to KWin for Picture-in-Picture bounds and minimize detection - #8
Merged
Merged
Conversation
OpenTubeX restores Picture-in-Picture bounds and detects minimizing on KDE Plasma Wayland through KWin scripts, which it loads over KWin's D-Bus interface. Without this name, the calls fail with ServiceUnknown.
2 of 5 tasks
This repository publishes to its own remote, so Flathub's default refusal of org.kde.KWin does not apply. A user exception file keeps every other lint error fatal, and the build job gets the file through the prepared manifest artifact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenTubeX remembers the Picture-in-Picture window bounds and detects minimizing on KDE Plasma Wayland through KWin scripts, which it loads over KWin's D-Bus interface. The Flatpak can't reach
org.kde.KWin, so those calls fail withServiceUnknownand both features stay off.This adds
--talk-name=org.kde.KWinto the finish args. The app side, which writes the scripts where KWin can read them and matches sandboxed windows by the Flatpak app ID, is in OpenTubeX/OpenTubeX#2863. The build runs on release and nightly dispatch, so this change takes effect with the next build.Flathub's linter rejects
org.kde.KWinby default (finish-args-kwin-talk-name). This repository publishes to its own remote, soflatpak-builder-lint-exceptions.jsonexempts only that check, with the reason, and bothvalidate.ymland the release build inbuild.ymlpass it with--exceptions --user-exceptions. The release build gets the file through the prepared manifest artifact, since that job has no checkout.Proof:
flatpak-builder-lintwith the exception file and the Python tests pass. A Flatpak built from this manifest with OpenTubeX/OpenTubeX#2863 ran end to end inside a nestedkwin_wayland --virtualsession on a private D-Bus bus. It loaded both KWin scripts, restored the Picture-in-Picture bounds after reopening and after a restart, and reported minimize to the renderer.Reviewed with sol-loop: 1 round with gpt-6.1-sol on high.
Sol verdict: approved
Made with Claude Opus 5.5 in Claude Code.