Skip to content

fix(font): apply requested system font weights - #1242

Merged
Kyle-Ye merged 1 commit into
mainfrom
bugfix/font_weight
Nov 1, 2026
Merged

Kyle-Ye merged 1 commit into
mainfrom
bugfix/font_weight

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Nov 1, 2026

Copy link
Copy Markdown
Member

Summary

  • Fix ignored weights in Font.system(size:weight:design:), preserving regular weight when omitted.
  • Add regression tests for standard weights and for bold and medium fonts across system designs.

Closes #1241.

@github-actions github-actions Bot added area: text Text, labels, line style, and text rendering APIs. type: bug Something is not working correctly. labels Nov 1, 2026
@tuist

tuist Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Ran test modules Commit
OpenSwiftUI ✅ 7 e3db823bd

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI ✅ 42.5s e3db823bd

@codecov

codecov Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.03%. Comparing base (e764438) to head (4410d48).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1242      +/-   ##
==========================================
+ Coverage   32.01%   32.03%   +0.01%     
==========================================
  Files         982      982              
  Lines       81217    81218       +1     
==========================================
+ Hits        26004    26016      +12     
+ Misses      55213    55202      -11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye merged commit e1f080c into main Nov 1, 2026
7 checks passed
@Kyle-Ye
Kyle-Ye deleted the bugfix/font_weight branch November 1, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: text Text, labels, line style, and text rendering APIs. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System font weight is ignored

1 participant