Skip to content

fix: use module selectors in Example observation models - #1236

Merged
Kyle-Ye merged 2 commits into
mainfrom
bugfix/observation
Oct 31, 2026
Merged

Kyle-Ye merged 2 commits into
mainfrom
bugfix/observation

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Summary

Follow up of #1232

  • Fix Example build failures caused by ambiguous @Observable macros when both Observation and OpenObservation are in scope.
  • Use OpenObservation::Observable or Observation::Observable for the active configuration in Example models and the observation interaction test.

Validation

  • Both Example configurations build on iOS Simulator, macOS, and visionOS Simulator with Xcode 26.6.
  • The focused iOS UI and observation interaction tests pass with existing references, including counter updates from 0 to 1 to 2.
  • The macOS UI test target and both observation interaction test configurations compile successfully.

Fixes #1235

@Kyle-Ye Kyle-Ye added this to the 0.25.0 milestone Oct 31, 2026
@github-actions github-actions Bot added area: data-flow State, binding, environment, preference, observation, or property data flow. area: example Example apps, previews, sample projects, screenshots, or demo assets. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: bug Something is not working correctly. labels Oct 31, 2026
@Kyle-Ye
Kyle-Ye requested a review from Mx-Iris as a code owner October 31, 2026 10:12
@Kyle-Ye

Kyle-Ye commented Oct 31, 2026

Copy link
Copy Markdown
Member Author

/uitest ios osui-iag

@tuist

tuist Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Ran test modules Commit
OpenSwiftUI ✅ 7 6e0a5d3f9

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI ✅ 44.3s 6e0a5d3f9

@codecov

codecov Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.35%. Comparing base (14d2285) to head (a62441a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1236   +/-   ##
=======================================
  Coverage   31.35%   31.35%           
=======================================
  Files         982      982           
  Lines       80761    80761           
=======================================
+ Hits        25320    25323    +3     
+ Misses      55441    55438    -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye merged commit 050fd53 into main Oct 31, 2026
8 of 9 checks passed
@Kyle-Ye
Kyle-Ye deleted the bugfix/observation branch October 31, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: data-flow State, binding, environment, preference, observation, or property data flow. area: example Example apps, previews, sample projects, screenshots, or demo assets. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix observation macro conflicts in Example

1 participant