Skip to content

feat: implement SymbolEffect SPI - #1205

Merged
Kyle-Ye merged 5 commits into
mainfrom
feature/symbolEffect
Oct 24, 2026
Merged

Kyle-Ye merged 5 commits into
mainfrom
feature/symbolEffect

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Oct 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Implement symbol effect configurations, environment modifiers, and transitions for symbol hiding and replacement.
  • Connect image animation updates to typed backend options and completion listeners.
  • Add type-erased equality and protobuf boundary fixes, with tests for triggers, layout direction, and encoding.
  • Update DarwinPrivateFrameworks and OpenRenderBox to their merged symbol animation revisions.

Dependency

Refs #1199.

@github-actions github-actions Bot added area: animation Animation, transitions, transactions, or timing behavior. area: graphics Color, shape, gradient, image, symbols, and graphics primitives. type: feature New API, behavior, platform support, or user-facing capability. labels Oct 24, 2026
@tuist

tuist Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Ran test modules Commit
OpenSwiftUI ✅ 7 b5b86d278

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI ✅ 44.9s b5b86d278

@codecov

codecov Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 19.39979% with 752 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.49%. Comparing base (da91cd9) to head (faf1905).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...wiftUICore/Render/SymbolEffect/_SymbolEffect.swift 31.40% 367 Missing ⚠️
...OpenSwiftUI/Render/SymbolEffect/SymbolEffect.swift 0.00% 363 Missing ⚠️
...urces/OpenSwiftUICore/Data/Util/AnyEquatable.swift 32.14% 19 Missing ⚠️
Sources/OpenSwiftUICore/View/Image/Image.swift 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
+ Coverage   29.95%   30.49%   +0.54%     
==========================================
  Files         950      951       +1     
  Lines       76140    77046     +906     
==========================================
+ Hits        22804    23498     +694     
- Misses      53336    53548     +212     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye merged commit 234d76e into main Oct 24, 2026
7 checks passed
@Kyle-Ye
Kyle-Ye deleted the feature/symbolEffect branch October 24, 2026 09:21
@Kyle-Ye Kyle-Ye linked an issue Oct 24, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: animation Animation, transitions, transactions, or timing behavior. area: graphics Color, shape, gradient, image, symbols, and graphics primitives. type: feature New API, behavior, platform support, or user-facing capability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement the symbol effect API

1 participant