Repository navigation
fix(geometry): support CGRect operations without CoreGraphics - #13
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
==========================================
+ Coverage 81.32% 84.26% +2.94%
==========================================
Files 19 20 +1
Lines 1012 1087 +75
==========================================
+ Hits 823 916 +93
+ Misses 189 171 -18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Darwin's standalone
CGRectextension lacks the bounds and rectangle operations needed by graphics clients. Add midpoint, null, standardization, containment, intersection, and union APIs, and correct bounds for negative sizes while keepingOpenCoreGraphicsindependent of the system CoreGraphics module.Add shared tests for negative sizes, null rectangles, edge containment, and degenerate intersections. Boundary-intersection expectations follow Darwin CoreGraphics for the OpenCoreGraphics implementation and record the Swift Foundation behavior used on Linux.
Local validation passed 18 geometry tests with each macOS backend and all 56 tests in debug and release on Linux with Swift 6.3.3.