Repository navigation
Conversation
DebugClient's TCP client is gated on canImport(Darwin), but it imports Network, which is not present on every Darwin-targeting SDK. Building for an arm64-apple-macosx target whose SDK has no Network.framework fails with "no such module 'Network'" before any of the debug code is reached. Widen the guard to the module the file actually needs. (cherry picked from commit 23d0ca0)
The test target compiles DebugClient.swift through a symlink and uses DebugClient, which now compiles out when Network is unavailable. Use the same guard in the test file so the target still builds on such SDKs.
Author
|
Review verdict for head 55cd87b: the cold review found that the test target compiles DebugClient.swift through a symlink and DebugServerTests.swift had only the Darwin guard. Fixed in a follow-up commit (same guard on the test file). Guard structure balances, no behavior change on SDKs with Network.framework. Not built: no Swift toolchain available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DebugClient.swiftis gated oncanImport(Darwin)but importsNetwork, which is not present in every Darwin-targeting SDK. Building for anarm64-apple-macosxtarget whose SDK has no Network.framework fails withno such module 'Network'.This widens the guard to
canImport(Darwin) && canImport(Network), the modules the file needs. One line. On SDKs that have Network.framework the condition is unchanged.Testing: not built. There is no Swift toolchain on the machine where this was prepared, so the change was checked by reading only.