Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NAM becomes a top-level tab while staying an ordinary
StageConfig::Namstage in the chain, so presets,chain_stateand the engine are unchanged. The Amp tab's NAM card shrinks to a link row. The hover-menu picker from #294 and theiced_awdependency are removed.What clicking a model does:
Where things live:
Model names wrap and are never clipped. Rows whose native rate differs from the engine rate are dimmed with the rate shown.
Evidence
Before:
make test334 passed.SharedApp::updatehad no tests.After:
make test368 passed,make lintclean.SharedApp::updateis now driven through a mock backend:git diff mainis empty forrustortion-core/src/{preset,amp,audio}andrustortion-plugin/src/params.rs.make pluginbuilt the CLAP and VST3 bundles at the seventh commit. It was not re-run after the last four fix commits (two of them comment-only or test-only).No screenshots: nothing here has been seen on screen yet. This stays a draft until the hand-test passes.
Hand-test, standalone:
NAM_Starterpreset: "No model loaded" with ⏻, × and the sliders present6505+,[amp]; clear with ×; a preset hotkey bound to a digit or to Enter does not fire while typingHand-test, plugin host:
Merge Danger
Door: two-way
No file-format,
chain_stateor host-parameter change. Reverting restores the old card, and presets saved on this branch load onmainunchanged.Blast Radius: GUI
The standalone and the plugin share this GUI, so both change. Unverified until the hand-test: layout at 800×600 and in the 900×700 plugin editor, and keyboard focus for the filter inside plugin hosts.
Known gaps, deliberately left:
screenshots/rustortion.pngandscreenshots/rustortion.zh-CN.pngstill show the old tab bar.