orchestrator: Add the ReportSink seam for the Report effects - #447
Merged
Conversation
chrysh
force-pushed
the
add-report-sink
branch
from
August 27, 2026 20:44
e957f93 to
fafe830
Compare
chrysh
marked this pull request as ready for review
August 27, 2026 20:54
The four Effect::Report* variants had no consumer seam. Add a non_exhaustive Report enum and one ReportSink::report, not a method or a trait per variant, plus a unit impl for a board with no management side to tell. report returns nothing: an error channel would put reports on the driver's fail-closed path, letting the act of reporting a contained failure escalate it. Trait only, composing a sink into the board follows. Assisted-by: Claude:claude-opus-5 Signed-off-by: Christina Quast <christina.quast@9elements.com>
chrysh
force-pushed
the
add-report-sink
branch
from
August 31, 2026 20:53
fafe830 to
32cc415
Compare
leongross
reviewed
Sep 2, 2026
rusty1968
reviewed
Sep 2, 2026
chrysh
force-pushed
the
add-report-sink
branch
from
September 3, 2026 08:56
32cc415 to
204f716
Compare
rusty1968
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four
Effect::Report*variants have no consumer seam. This adds a#[non_exhaustive]Reportenum and a singleReportSink::reportinstead of a method or a trait per variant, so a new report is one variant rather than a trait break and a sink routes only what it recognises.reportreturns nothing: a report names something that already happened, so an undeliverable one costs information, not containment, and reporting stays off the driver's fail-closed path. Payloads stayCopyand lifetime-free, like the effects they mirror.The seam lives in
driver/src/board.rsrather thanorchestrator-capabilities, becauseReportcarries aComponentIdand that crate is a dependency-free leaf. Same split the driver already makes forVerifier.Composing a sink into the board follows in the next PR.
References 9elements#3.