Build SMPGC only with COLPACK_ENABLE_OPENMP - #14
Merged
AnHeuermann merged 1 commit intoSep 24, 2026
Merged
Conversation
SMPGC includes <omp.h> unconditionally, so COLPACK_ENABLE_OPENMP=OFF failed to compile wherever the compiler has no OpenMP headers, such as Apple clang without Homebrew's libomp. The rest of ColPack only uses OpenMP under _OPENMP. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
COLPACK_ENABLE_OPENMP=OFFdoes not build where the compiler has no OpenMP headers, for example Apple clang without Homebrew's libomp:Needed for OpenModelica/OMCompiler-3rdParty#245, which turns ColPack's OpenMP off by default in OpenModelica.
Approach
SMPGC is the OpenMP-parallel coloring and includes
<omp.h>unconditionally. The rest of ColPack only uses OpenMP under_OPENMP. SMPGC's sources, headers and include directory are now only added withCOLPACK_ENABLE_OPENMP.Tested on Linux (gcc) with
COLPACK_ENABLE_TESTS=ONandCOLPACK_BUILD_SHARED=ON:OFF, with anomp.hthat is an#errorput first on the include path: builds, 5/5 tests pass.ON: SMPGC is built as before, 5/5 tests pass.🤖 Generated with Claude Code