Read SAML parameters from their binding in the .NET Fedlet; run e2e scripts without a shell

e2e/saml/saml-test.spec.mjs

@@ -17,7 +17,7 @@
 
 // openam.spec.mjs – ESM edition
 import { test, expect } from "@playwright/test";
-import { execSync } from "child_process";
+import { execFileSync } from "child_process";
 import { resolve } from "path";
 import { fileURLToPath } from "url";
 import { PASSWORD, USERNAME } from "../common/openam-commons.mjs";
@@ -51,7 +51,8 @@ const SEL = {
 
 const execScript = (scriptPath) => {
   try {
-    execSync(`bash "${scriptPath}"`, {
+    // No shell: the script path is handed to bash as an argument, not interpolated.
+    execFileSync("bash", [scriptPath], {
       encoding: "utf-8",
       timeout: 300_000,   // 5 minutes max
       stdio: "inherit",

openam-federation/openam-federation-library/src/main/csharpsource/Fedlet/Fedlet/source/Saml2/ServiceProviderUtility.cs

@@ -26,6 +26,7 @@
  */
 /*
  * Portions Copyrighted 2011-2016 ForgeRock AS.
+ * Portions Copyrighted 2026 3A Systems LLC.
  */
 
 using System;
@@ -275,26 +276,26 @@ public AuthnResponse GetAuthnResponse(HttpContext context)
             HttpRequest request = context.Request;
 
             // Check if a saml response was received...
-            if (string.IsNullOrEmpty(request[Saml2Constants.ResponseParameter])
-                && string.IsNullOrEmpty(request[Saml2Constants.ArtifactParameter]))
+            if (string.IsNullOrEmpty(GetBindingParameter(request, Saml2Constants.ResponseParameter))
+                && string.IsNullOrEmpty(GetBindingParameter(request, Saml2Constants.ArtifactParameter)))
             {
                 throw new ServiceProviderUtilityException(Resources.ServiceProviderUtilityNoSamlResponseReceived);
             }
 
             // Obtain AuthnResponse object from either HTTP-POST or HTTP-Artifact
-            if (request[Saml2Constants.ResponseParameter] != null)
+            if (GetBindingParameter(request, Saml2Constants.ResponseParameter) != null)
             {
-                string samlResponse = Saml2Utils.ConvertFromBase64(request[Saml2Constants.ResponseParameter]);
+                string samlResponse = Saml2Utils.ConvertFromBase64(GetBindingParameter(request, Saml2Constants.ResponseParameter));
                 authnResponse = new AuthnResponse(samlResponse);
 
                 XmlDocument xmlDoc = (XmlDocument)authnResponse.XmlDom;
                 StringBuilder logMessage = new StringBuilder();
                 logMessage.Append("AuthnResponse:\r\n").Append(xmlDoc.OuterXml);
                 FedletLogger.Info(logMessage.ToString());
             }
-            else if (request[Saml2Constants.ArtifactParameter] != null)
+            else if (GetBindingParameter(request, Saml2Constants.ArtifactParameter) != null)
             {
-                Artifact artifact = new Artifact(request[Saml2Constants.ArtifactParameter]);
+                Artifact artifact = new Artifact(GetBindingParameter(request, Saml2Constants.ArtifactParameter));
                 artifactResponse = this.GetArtifactResponse(artifact);
                 authnResponse = artifactResponse.AuthnResponse;
 
@@ -357,14 +358,14 @@ public LogoutRequest GetLogoutRequest(HttpContext context)
             // Obtain the LogoutRequest object...
             if (request.HttpMethod == "GET")
             {
-                samlRequest = Saml2Utils.ConvertFromBase64Decompress(request[Saml2Constants.RequestParameter]);
+                samlRequest = Saml2Utils.ConvertFromBase64Decompress(GetBindingParameter(request, Saml2Constants.RequestParameter));
             }
             else if (request.HttpMethod == "POST")
             {
                 // something posted...check if soap vs form post
-                if (!String.IsNullOrEmpty(request[Saml2Constants.RequestParameter]))
+                if (!String.IsNullOrEmpty(GetBindingParameter(request, Saml2Constants.RequestParameter)))
                 {
-                    samlRequest = Saml2Utils.ConvertFromBase64(request[Saml2Constants.RequestParameter]);
+                    samlRequest = Saml2Utils.ConvertFromBase64(GetBindingParameter(request, Saml2Constants.RequestParameter));
                 }
                 else
                 {
@@ -441,20 +442,20 @@ public LogoutResponse GetLogoutResponse(HttpContext context)
             HttpRequest request = context.Request;
 
             // Check if a saml response was received...
-            if (String.IsNullOrEmpty(request[Saml2Constants.ResponseParameter]))
+            if (String.IsNullOrEmpty(GetBindingParameter(request, Saml2Constants.ResponseParameter)))
             {
                 throw new ServiceProviderUtilityException(Resources.ServiceProviderUtilityNoSamlResponseReceived);
             }
 
             // Obtain the LogoutRequest object...
             if (request.HttpMethod == "GET")
             {
-                string samlResponse = Saml2Utils.ConvertFromBase64Decompress(request[Saml2Constants.ResponseParameter]);
+                string samlResponse = Saml2Utils.ConvertFromBase64Decompress(GetBindingParameter(request, Saml2Constants.ResponseParameter));
                 logoutResponse = new LogoutResponse(samlResponse);
             }
             else
             {
-                string samlResponse = Saml2Utils.ConvertFromBase64(request[Saml2Constants.ResponseParameter]);
+                string samlResponse = Saml2Utils.ConvertFromBase64(GetBindingParameter(request, Saml2Constants.ResponseParameter));
                 logoutResponse = new LogoutResponse(samlResponse);
             }
 
@@ -1679,6 +1680,19 @@ public void ValidateForRedirect(LogoutResponse logoutResponse, ICollection logou
 
         #region Static Private Methods
 
+        /// <summary>
+        /// Gets a SAML message parameter from where its binding carries it: the form of a
+        /// POST, the query string of a GET. The request's own indexer would also consult
+        /// cookies and server variables, which no SAML binding uses.
+        /// </summary>
+        /// <param name="request">The current request.</param>
+        /// <param name="name">The parameter name, for example SAMLResponse.</param>
+        /// <returns>The parameter value, or null if the request does not carry it.</returns>
+        private static string GetBindingParameter(HttpRequest request, string name)
+        {
+            return request.HttpMethod == "POST" ? request.Form[name] : request.QueryString[name];
+        }
+
         /// <summary>
         /// Checks the time condition of the given AuthnResponse.
         /// </summary>

openam-federation/openam-federation-library/src/main/csharpsource/Fedlet/SampleApp/Web.config

@@ -12,6 +12,6 @@
     <pages controlRenderingCompatibilityVersion="3.5" clientIDMode="AutoID" />
   </system.web>
     <system.webServer>
-        <directoryBrowse enabled="true" />
+        <directoryBrowse enabled="false" />
     </system.webServer>
 </configuration>