Williampunk - #97
Conversation
…ices/t20_ultimate_azarton-c1/general/overlay/etc/modules
openipc-ai
left a comment
There was a problem hiding this comment.
Thanks for working on the Qihoo D706 — a T20 board with no usable Ethernet PHY is a useful addition. But this branch can't merge as it stands, because of how the new device was created.
Blocking: this rewrites an existing, working camera
The D706 was added by editing devices/t20_ultimate_azarton-c1/ in place instead of copying it to a new directory. The Azarton C1 (T20X, JXF23, RTL8189FS_SDIO, listed done in the README) is a separate shipping device, and on this branch it becomes a second copy of the D706:
fw_setenv upgrade '.../t20_ultimate_azarton-c1-nor.tgz'is deleted — the camera loses self-update entirely.BR2_OPENIPC_SNS_MODELchangesjxf23→gc2023, and the customizer starts settingfw_setenv sensor gc2023. The Azarton has a JXF23.fw_setenv osmemdrops 64M → 40M andrmem64M → 24M.BR2_OPENIPC_VARIANTflipsultimate→litewhile the directory is still namedt20_ultimate_..., and majestic-webui, fonts, opus, lame, quirc, mosquitto and wireguard are dropped from it.fw_setenv extras nogmacis added, which is a D706 property — the Azarton has working Ethernet.
Anyone flashing the Azarton nightly after this would get a broken image. It is also a SMOKE_TARGET in .github/scripts/ci-matrix.py (it covers Ingenic ultimate), and I confirmed --self-test still passes with this branch applied — so CI would not catch it either.
Fix: revert everything under devices/t20_ultimate_azarton-c1/ back to master and keep only the new devices/t20_lite_qihoo-*/ directory. Copying a sibling and editing the copy is the intended flow.
Also needed
- Directory case. The directory is
t20_lite_qihoo-D706but the defconfig inside ist20_lite_qihoo-d706_defconfig. Device directory names are lowercase and must match the defconfig basename — that name is theBOARDtoken. Please rename the directory tot20_lite_qihoo-d706. - No
upgradeURL. The newcustomizer.shnever callsfw_setenv upgrade, so the device can't self-update. It needsfw_setenv upgrade 'https://github.com/OpenIPC/builder/releases/download/latest/t20_lite_qihoo-d706-nor.tgz', with the filename matching the directory name exactly. - Drop
BR2_PACKAGE_JSONFILTER=y. #128 removed it from all 97 defconfigs after firmware/#2304 — it drags in libubox for nothing unless the device enables uqmi-openipc or wifibroadcast-ng. - PR title. "Williampunk" doesn't say what the change does; something like
t20: add Qihoo D706 (GC2023, RTL8189FS)would help.
No master.yml entry is needed any more, by the way — since #120 the matrix is read off the tree, so the new directory registers itself and PR CI will build it, narrowed to just that device.
No description provided.