Repository navigation
Conversation
…ndary) shQuote() stripped every double quote from option values before wrapping them in double quotes for the shell. JSON options (--boundary, WebODM's crop polygon) therefore reached ODM without quotes and failed with "is not a valid JSON string". On POSIX use single quotes, which keep the value literally; Windows behaviour is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A6nSKVeapxTouZcAYh6UF6
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 7328aba ("Quote params and use shell: true"),
shQuote()strips every double quote from an option value before wrapping it in double quotes for the shell. JSON options therefore reach ODM without their quotes, e.g.--boundary(also used by WebODM for the crop polygon) fails with:Forum report: https://community.opendronemap.org/t/26994
This PR uses POSIX single quoting on non-Windows platforms (
'value', embedded'escaped as'\''), which passes the value to ODM literally. Windows behaviour is unchanged.Tested with the real
libs/odmRunner.jsand a stubrun.shthat applies ODM'spath_or_json_stringcheck, using the GeoJSON polygon from the forum post:... is not a valid JSON string., exit 2🤖 Generated with Claude Code
https://claude.ai/code/session_01A6nSKVeapxTouZcAYh6UF6