Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pyoaev/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,9 @@ def http_put(
raw=raw,
**kwargs,
)
if not raw and not result.content:
# void endpoints answer 2xx with an empty body
return {}
try:
json_result = result.json()
if TYPE_CHECKING:
Expand Down
41 changes: 41 additions & 0 deletions test/apis/inject_expectation/test_inject_expectation.py
Original file line number Diff line number Diff line change
Expand Up @@ -370,5 +370,46 @@ def test_older_platform_returns_no_model(self):
self.assertEqual([], models)


class TestBulkUpdate(TestCase):
@mock.patch("requests.Session.request")
def test_empty_2xx_body_is_success(self, mock_request):
class EmptyResponse:
status_code = 200
history = None
content = b""
headers = {}

def json(self):
raise ValueError("Expecting value: line 1 column 1 (char 0)")

mock_request.return_value = EmptyResponse()
api_client = OpenAEV("url", "token")

result = api_client.inject_expectation.bulk_update(
{"exp-1": {"collector_id": "c-1", "result": "Detected", "is_success": True}}
)

self.assertIsNone(result)
_, kwargs = mock_request.call_args
self.assertEqual(kwargs["url"], "url/api/injects/expectations/bulk")

@mock.patch("requests.Session.request")
def test_non_json_non_empty_body_still_raises(self, mock_request):
class HtmlResponse:
status_code = 200
history = None
content = b"<html>"
headers = {}

def json(self):
raise ValueError("Expecting value")

mock_request.return_value = HtmlResponse()
api_client = OpenAEV("url", "token")

with self.assertRaises(OpenAEVParsingError):
api_client.inject_expectation.bulk_update({"exp-1": {}})


if __name__ == "__main__":
main()
Loading