Skip to content

refactor: remove asset_group from models and related components (#8550) - #378

Merged
Grégoire FOUILLARD (gregfouillard) merged 1 commit into
mainfrom
feature/removal-assets-group
Nov 13, 2026
Merged

Grégoire FOUILLARD (gregfouillard) merged 1 commit into
mainfrom
feature/removal-assets-group

Conversation

@gregfouillard

Copy link
Copy Markdown
Contributor

Proposed changes

  • Removal of asset_group from SignatureTarget since it is not needed

Testing Instructions

  1. Step-by-step how to test
  2. Environment or config notes

Related issues

  • Related #8550

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the removal of the unused asset_group field and corresponding payload and fixture updates.

No open issues 🎉

What changed in this PR

Removes the unused asset_group field from SignatureTarget and aligns signature payload construction and test fixtures with the simplified model.

Changes:

  • Removes asset_group from the model and stops passing it during payload construction.
  • Updates the payload documentation and test fixtures to use only agent and asset metadata.
File Description
test/​signatures/​test_signature_manager_transmission.py Removes asset_group from canonical and large-payload fixtures.
test/​signatures/​test_signature_manager_build_payload.py Removes asset_group_id from the target fixture.
pyoaev/​signatures/​signature_manager.py Stops passing asset_group and updates the metadata docstring.
pyoaev/​signatures/​models.py Removes the optional asset_group field from SignatureTarget.

Review effort: Balanced

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good. To merge together with or after OpenAEV-Platform/openaev#8884, since the server still reads asset_group today.

@gregfouillard
Grégoire FOUILLARD (gregfouillard) merged commit 4ce6e0f into main Nov 13, 2026
14 of 16 checks passed
@gregfouillard
Grégoire FOUILLARD (gregfouillard) deleted the feature/removal-assets-group branch November 13, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants