Repository navigation
refactor: remove asset_group from models and related components (#8550) - #378
Merged
Grégoire FOUILLARD (gregfouillard) merged 1 commit intoNov 13, 2026
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the removal of the unused asset_group field and corresponding payload and fixture updates.
No open issues 🎉
What changed in this PR
Removes the unused asset_group field from SignatureTarget and aligns signature payload construction and test fixtures with the simplified model.
Changes:
- Removes
asset_groupfrom the model and stops passing it during payload construction. - Updates the payload documentation and test fixtures to use only agent and asset metadata.
| File | Description |
|---|---|
test/signatures/test_signature_manager_transmission.py |
Removes asset_group from canonical and large-payload fixtures. |
test/signatures/test_signature_manager_build_payload.py |
Removes asset_group_id from the target fixture. |
pyoaev/signatures/signature_manager.py |
Stops passing asset_group and updates the metadata docstring. |
pyoaev/signatures/models.py |
Removes the optional asset_group field from SignatureTarget. |
Review effort: Balanced
Grégoire FOUILLARD (gregfouillard)
requested review from
Frédéric BASLER (Megafredo) and
Romuald Lemesle (RomuDeuxfois)
November 9, 2026 09:10
Grégoire FOUILLARD (gregfouillard)
requested a review
from Christophe Melchior (Kakudou)
November 9, 2026 09:12
Romuald Lemesle (RomuDeuxfois)
approved these changes
Nov 12, 2026
Romuald Lemesle (RomuDeuxfois)
left a comment
Member
There was a problem hiding this comment.
Thanks! Looks good. To merge together with or after OpenAEV-Platform/openaev#8884, since the server still reads asset_group today.
Ferdinand (guzmud)
approved these changes
Nov 13, 2026
Grégoire FOUILLARD (gregfouillard)
merged commit Nov 13, 2026
4ce6e0f
into
main
14 of 16 checks passed
Grégoire FOUILLARD (gregfouillard)
deleted the
feature/removal-assets-group
branch
November 13, 2026 13:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Testing Instructions
Related issues
Checklist
Further comments