Skip to content

feat(credentials): add sovereign cloud process (#8762) - #373

Merged
Gabriel Pezé (gabriel-peze) merged 4 commits into
mainfrom
issue/8762
Nov 12, 2026
Merged

Gabriel Pezé (gabriel-peze) merged 4 commits into
mainfrom
issue/8762

Conversation

@gabriel-peze

Copy link
Copy Markdown
Contributor

Proposed changes

  • Use the new inputs fields on OpenAEV to allow the access of sovereign clouds

Testing Instructions

  1. Run Prowler and/or Stratus and use the new fields with the last version of OpenAEV
  2. The inject should run with these new values

FYI : You can test with floci or another mocked cloud

Related issues

  • Relates #8762

@github-actions github-actions Bot added the filigran team Item from the Filigran team. label Oct 29, 2026
@gabriel-peze
Gabriel Pezé (gabriel-peze) marked this pull request as ready for review October 30, 2026 13:08
Copilot AI balanced review requested due to automatic review settings October 30, 2026 13:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Prowler ignores the Google endpoint and access-token overrides, while the Azure authority override incorrectly redirects managed-identity requests to the login server, causing authentication failures.

4 open issues
What changed in this PR

This PR extends credential resolution and materialization with sovereign and mock cloud settings intended for Prowler and Stratus integrations.

Changes:

  • Adds optional AWS, Azure, and GCP endpoint and authentication fields.
  • Exports cloud configuration variables and writes Azure CA certificates to temporary files.
  • Adds tests for parsing, environment mappings, sensitive-value redaction, and certificate cleanup.
File Description
test/​credential/​test_credential_resolved.py Tests new fields, defaults, certificate decoding, and redaction.
test/​credential/​test_credential_materializer.py Tests environment overrides and certificate file lifecycle.
pyoaev/​credential/​resolved.py Adds optional sovereign-cloud fields to credential models.
pyoaev/​credential/​materializer.py Maps new fields to environment variables and temporary CA files.

Review effort: Balanced

Comment thread pyoaev/credential/materializer.py Resolved
Comment thread pyoaev/credential/materializer.py Resolved
Comment thread pyoaev/credential/materializer.py Resolved
Comment thread pyoaev/credential/materializer.py Resolved

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tho work done on that PR.
Sadly i had to put it in request changes for a little thing, in materializer.py about azure-identity that could lead to missbehaviour.

Comment thread pyoaev/credential/materializer.py Resolved
Comment thread pyoaev/credential/materializer.py Resolved
Comment thread pyoaev/credential/materializer.py Resolved
Comment thread pyoaev/credential/materializer.py Resolved
Comment thread pyoaev/credential/resolved.py Resolved
- azure: stop setting AZURE_POD_IDENTITY_AUTHORITY_HOST from the authority
  host; azure-identity reads it as the managed identity (IMDS) endpoint
- gcp: also export the access token as CLOUDSDK_AUTH_ACCESS_TOKEN and the
  project as GOOGLE_CLOUD_PROJECT, the variables Prowler reads
- validate endpoint URLs at parse time (http(s), https for the Azure
  authority, host required, no whitespace or userinfo)
- require a PEM Azure CA certificate; DER is rejected early
- aws: reword the endpoint comment (mock or proxy, not a sovereign partition)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
+ Coverage   85.55%   85.79%   +0.24%     
==========================================
  Files          64       64              
  Lines        3164     3218      +54     
==========================================
+ Hits         2707     2761      +54     
  Misses        457      457              
Files with missing lines Coverage Δ
pyoaev/credential/materializer.py 100.00% <100.00%> (ø)
pyoaev/credential/resolved.py 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i don't see any bottleneck from the code overview, and you have fixed all of my previous feedbacks.

Ty for the work done ! 🤘

@gabriel-peze
Gabriel Pezé (gabriel-peze) merged commit 0f692c5 into main Nov 12, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants