Repository navigation
feat(credentials): add sovereign cloud process (#8762) - #373
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Prowler ignores the Google endpoint and access-token overrides, while the Azure authority override incorrectly redirects managed-identity requests to the login server, causing authentication failures.
4 open issues
What changed in this PR
This PR extends credential resolution and materialization with sovereign and mock cloud settings intended for Prowler and Stratus integrations.
Changes:
- Adds optional AWS, Azure, and GCP endpoint and authentication fields.
- Exports cloud configuration variables and writes Azure CA certificates to temporary files.
- Adds tests for parsing, environment mappings, sensitive-value redaction, and certificate cleanup.
| File | Description |
|---|---|
test/credential/test_credential_resolved.py |
Tests new fields, defaults, certificate decoding, and redaction. |
test/credential/test_credential_materializer.py |
Tests environment overrides and certificate file lifecycle. |
pyoaev/credential/resolved.py |
Adds optional sovereign-cloud fields to credential models. |
pyoaev/credential/materializer.py |
Maps new fields to environment variables and temporary CA files. |
Review effort: Balanced
Christophe Melchior (Kakudou)
left a comment
There was a problem hiding this comment.
Thanks for tho work done on that PR.
Sadly i had to put it in request changes for a little thing, in materializer.py about azure-identity that could lead to missbehaviour.
- azure: stop setting AZURE_POD_IDENTITY_AUTHORITY_HOST from the authority host; azure-identity reads it as the managed identity (IMDS) endpoint - gcp: also export the access token as CLOUDSDK_AUTH_ACCESS_TOKEN and the project as GOOGLE_CLOUD_PROJECT, the variables Prowler reads - validate endpoint URLs at parse time (http(s), https for the Azure authority, host required, no whitespace or userinfo) - require a PEM Azure CA certificate; DER is rejected early - aws: reword the endpoint comment (mock or proxy, not a sovereign partition) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5abb50e to
367a4ff
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
+ Coverage 85.55% 85.79% +0.24%
==========================================
Files 64 64
Lines 3164 3218 +54
==========================================
+ Hits 2707 2761 +54
Misses 457 457
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Christophe Melchior (Kakudou)
left a comment
There was a problem hiding this comment.
LGTM, i don't see any bottleneck from the code overview, and you have fixed all of my previous feedbacks.
Ty for the work done ! 🤘

Proposed changes
Testing Instructions
FYI : You can test with floci or another mocked cloud
Related issues