fix(lsp): never scan the filesystem root for an opened document's siblings - #489
Merged
Merged
Conversation
…lings Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Since sibling-import indexing landed (#467),
Server.indexOpenedDirectoryscans the directory of any document opened outside every workspace folder. Thecmd/sysml-lsptests open documents atfile:///m.sysml, so the server walked/with its 2000-directory budget. On CircleCI that walk reaches/home/circleci/project/examplesand parses thousands of corpus models before the budget runs out:TestStrictFlagServesStrictDiagnosticstook over 17 minutes per subtest, and everydevelopbuild since #467 has failedGo race tests(no output for 30 min) andGo coverage profile(cmd/sysml-lsphit the 30 mingo testtimeout).indexOpenedDirectorynow returns before taking the lock whenfilepath.Dir(name)is the volume root (/,C:\). A document at the root has no workspace and no plausible sibling set, and the walk from there is unbounded in work even when bounded in directories.How it was verified
TestOpeningFileAtFilesystemRootIndexesNothingininternal/frontend/lsp: opening/m.sysmlrecords noopenDirsand publishes no diagnostics.go test -count=1 -race -run TestStrictFlagServesStrictDiagnostics ./cmd/sysml-lspnow completes in under 2 s.gofmt -l,go vet,go test ./internal/frontend/lsp,python3 scripts/changelog.py checkclean.Checklist
make testandmake lintpass locally (targeted packages; the full suite runs in CI)changes/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved (compliance rows need nothing: the census is counted at docs build)F4,K5) in the body, docs, or changelog