311-various-macos-issues-mostly-to-do-with-mouse-inputs

[Johnnyg63]

@SteveBirtles, reported and fixed the below issues. All have been tested, Please see #311 for issue, pdf can be downloaded here: https://github.com/user-attachments/files/32536930/MacOS.specific.patches.for.olcPixelGameEngine3-1.pdf

• Resizing the window on a retina display caused the mouse position to be reported wrong (pixel vs ‘point’ scaling). Items 1 and 2 below fix this…_ :
  • Corrected
  • Corrected
• Program would crash when an attempt was made to close it due to queued window events, fixed by item 3…
  • Sorry I could not reproduce the issue, we also have fixed these issues in Correct return false from onUserUpdate() causing cross threading #228 RAII and clean exit failing on MacOS #234 , however we are maybe seening a new issued reported in windows Delay to close application after returning false from OnUserUpdate on Windows #312 therefore I implemented your fix to be sure, thank you :)
• On MacOS, the trackpad sends type 3 which meant clicks were ignored and mouse stayed at (0,0). Fixed with item 4, 5 and 6…
  • All 3 items corrected, I didn't have a macBook / Neo so I was really able to test this fully, sp again great catch and brilliant fix!!!
• A tricky one, this. Changing the mouse visibility or position could deadlock, with two threads waiting on each other, so the program hung. Making the event dispatches
  asynchronous and adding a 16ms limit on the wait (one frame) resolved this issue, as seen in item 7 and 8…
  • I could not reproduce, however it is a tricky one/rare that this could happen so:
  • I implemented item 7
  • However for item 8, hardcoding a delay of 16ms or adding a magic numbers will have all the other Guru's on my back.
  • Therefore I added a MainThread task SET_MOUSE_POSITION to handle it

case SET_MOUSE_POSITION:
{
    // Set mouse position on main thread
    pMacOSWindow->setCursorPosition(vPositionMouse.x, vPositionMouse.y);
    res = false; // No need to skip frame
    break;
}