Miniaudio pgex - #305
Merged
Merged
Miniaudio pgex#305
Conversation
Owner
|
yeah thanks moros, its now in :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know if there's anything about it that screams "oh heck no!!!", I fix it 😃
A few notes
The extension's demo will appear in cmake as
ext_demo_Miniaudio, I propose we make this standard for the extensions. It will have the effect of having the extension demos grouped near eachother in cmake's list of targets.The documentation is mostly complete, the one area that needs help (and I note it directly in the docs, there's a call to action to get a more useful example for the synthesis callback! Since I'm not a low-level synthesis sound guy, I leave that to wiser minds.