Skip to content

Eliminate unnecessary nested statement(s) within else clauses - #322

Closed
csware wants to merge 1 commit into
OWASP:mainfrom
csware:cleanup-nestedelse
Closed

Eliminate unnecessary nested statement(s) within else clauses#322
csware wants to merge 1 commit into
OWASP:mainfrom
csware:cleanup-nestedelse

Conversation

@csware

@csware csware commented Feb 2, 2024

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Sven Strickroth <email@cs-ware.de>
@csware
csware force-pushed the cleanup-nestedelse branch from dbd6d09 to 81d7404 Compare February 2, 2024 22:56
@mikesamuel

Copy link
Copy Markdown
Contributor

This PR does what it says on the tin.

Is this driven by some IDE warning?

@csware

csware commented Mar 22, 2024

Copy link
Copy Markdown
Contributor Author

Eclipse shows some warning, but I think it also makes the code better readable.

@aalmiray
aalmiray force-pushed the main branch 6 times, most recently from 9bb458a to f40152f Compare January 3, 2026 02:00
@jmanico

jmanico commented Sep 7, 2026

Copy link
Copy Markdown
Member

This still merges cleanly against current main. @mikesamuel's only question was what prompted it, and the answer (Eclipse warning, readability) is fine by me. I am running the build against it stacked with the other pending PRs on a verification branch, and will merge on green, @csware.

jmanico added a commit that referenced this pull request Sep 7, 2026
Eliminate unnecessary nested statements within else clauses (rebased #322)
@jmanico

jmanico commented Sep 7, 2026

Copy link
Copy Markdown
Member

Merged via #391, rebased onto the module layout with your authorship preserved, @csware. GitHub could not merge this branch directly because it is based on the pre-module tree. Thanks!

@jmanico jmanico closed this Sep 7, 2026
jmanico pushed a commit to Raibipasha-24/java-html-sanitizer that referenced this pull request Sep 8, 2026
Rebased from PR OWASP#322 by Sven Strickroth onto the module layout; the
original branch predates the move of sources under
owasp-java-html-sanitizer/. Pure restructuring, no behaviour change.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SKUuD1GhUfpvrDvJen6r91
@csware
csware deleted the cleanup-nestedelse branch September 8, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants