Skip to content

add inAttribute and change parameter order - #267

Closed
yangbongsoo wants to merge 1 commit into
OWASP:mainfrom
yangbongsoo:add-inAttribute-comment
Closed

add inAttribute and change parameter order#267
yangbongsoo wants to merge 1 commit into
OWASP:mainfrom
yangbongsoo:add-inAttribute-comment

Conversation

@yangbongsoo

Copy link
Copy Markdown
Contributor

First of all, thank you for continuously doing the version up.

  1. Added comment for newly added inAttribute in appendDecodedEntity method.
  2. Like the order of the appendDecodedEntity method parameter, I modified it because I thought it would be more natural to have the html parameter come first. Since the inAttribute parameter is used first inside mayComplete method, it can be said that it was declared first, so if you say no, I will roll back.

@aalmiray
aalmiray force-pushed the main branch 6 times, most recently from 9bb458a to f40152f Compare January 3, 2026 02:00
jmanico added a commit that referenced this pull request Sep 7, 2026
Document inAttribute parameter in HtmlEntities (rebased #267)
@jmanico

jmanico commented Sep 7, 2026

Copy link
Copy Markdown
Member

Merged via #386, rebased onto the current module layout with your authorship preserved, @yangbongsoo. Thank you, and sorry it took four years.

@jmanico jmanico closed this Sep 7, 2026
jmanico pushed a commit to Raibipasha-24/java-html-sanitizer that referenced this pull request Sep 8, 2026
Rebased from PR OWASP#267 onto the module layout; the original patch
predates the move of sources under owasp-java-html-sanitizer/.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SKUuD1GhUfpvrDvJen6r91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants